Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Clean up dependencies #1696

Merged
merged 3 commits into from
Mar 15, 2021
Merged

refactor: Clean up dependencies #1696

merged 3 commits into from
Mar 15, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Mar 12, 2021 •
edited
Loading

PR removes a couple of unused dependencies

Test Plan

How do we know the code works?

Both build and IT run finish without any error

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2021 •
edited
Loading

Timestamp: 2021-03-15 07:51:39
Buildscan url for ubuntu-workflow run 653392609
https://gradle.com/s/ummuznlvyjupc

@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/xgbjk7ryihpja
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/645734201

@pawelpasterz pawelpasterz force-pushed the dependencies-clean-up branch from 95e7a67 to da442cb Compare March 12, 2021 12:19
Sloox
Sloox previously requested changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure of these changes I somehow think some of them like:
api(Dependencies.Fuel.KOTLINX_SERIALIZATION)
are needed?

@Sloox
Copy link
Contributor

Sloox commented Mar 12, 2021

Ahh i see they are succeeding :)

@pawelpasterz
Copy link
Contributor Author

Work is still in progress, there might be some changes as I'm experimenting a bit 😅

@pawelpasterz pawelpasterz changed the title Optimize dependencies Clean up dependencies Mar 15, 2021
@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/76ku3435pgv22
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/653039516

@pawelpasterz pawelpasterz marked this pull request as ready for review March 15, 2021 05:56
@pawelpasterz pawelpasterz requested a review from Sloox March 15, 2021 05:56
@pawelpasterz pawelpasterz changed the title Clean up dependencies refactor: Clean up dependencies Mar 15, 2021
Sloox
Sloox approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to remove dependencies, can speed things up. Lets just hope we don't need them later.

@piotradamczyk5 piotradamczyk5 self-requested a review March 15, 2021 13:06
@mergify mergify bot merged commit 14bab1d into master Mar 15, 2021
@mergify mergify bot deleted the dependencies-clean-up branch March 15, 2021 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@Sloox Sloox Sloox approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelpasterz @Sloox @piotradamczyk5