Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Output path to local results github action #1694

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Mar 11, 2021

As you can see for example in this run, output contains file name:

Local directory: /home/runner/work/flank-github-action-testing/flank-github-action-testing/results/2021-03-11_15-13-11.697000_GzOA/android_shards.json
Gcloud: https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-03-11_15-13-11.697000_GzOA

but it should be:

Local directory: /home/runner/work/flank-github-action-testing/flank-github-action-testing/results/2021-03-11_15-13-11.697000_GzOA
Gcloud: https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-03-11_15-13-11.697000_GzOA

This is a quick workaround to avoid making a new Flank release, when we will fix this on Flank side, it should be removed from Flank github action

Test Plan

How do we know the code works?

There should not be a file name at the end

Locally:

  1. Create file flank-links.log with path to some file as a content
  2. run command file_path=$(find -name "flank-links.log")
  3. then local_directory_file=$(sed -n '1p' < $file_path)
  4. at the end echo results echo $(dirname $local_directory_file)

Github action:
Should return local path without file name at the end

@github-actions
Copy link
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

Timestamp: 2021-03-11 15:41:09
Buildscan url for ubuntu-workflow run 643274041
https://gradle.com/s/rprlzxgybyd7q

@piotradamczyk5 piotradamczyk5 merged commit ab3903c into master Mar 11, 2021
@piotradamczyk5 piotradamczyk5 deleted the fix_output_path branch March 11, 2021 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants