fix: Fix output report error with dump shards #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
bootstraponline
force-pushed
the
fix-output-report-error-with-dump-shards
branch
from
a70efd2 to
67f0a5a
Compare
pawelpasterz
force-pushed
the
fix-output-report-error-with-dump-shards
branch
from
67f0a5a to
b4b8ee5
Compare
|
@flank-it |
|
Integration tests succeed for all OSes ✅ |
|
Timestamp: 2021-03-11 11:02:42 |
Sloox
approved these changes
Mar 11, 2021
| @@ -111,7 +111,7 @@ fun File.hasAllFiles(fileList: List<String>): Boolean { | |||
|
|
|||
| fun String.fileExists(): Boolean = Paths.get(this).exists() | |||
|
|
|||
| fun osPathSeperator() = (if (isWindows) "\\" else "/") | |||
| fun osPathSeparator() = (if (isWindows) "\\" else "/") | |||
There was a problem hiding this comment.
Am i blind what actually changed on this line?
There was a problem hiding this comment.
There was a typo sepErator. I've changed it to sepArator
There was a problem hiding this comment.
is it different from File.pathSeparator ?
bootstraponline
force-pushed
the
fix-output-report-error-with-dump-shards
branch
from
b4b8ee5 to
1473b3a
Compare
adamfilipow92
approved these changes
Mar 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user tries to dump shards AND the output report is enabled an error is thrown. This is due to the fact flank is trying to create
outputReport.jsonfile inside result directory which does not exist for dump shard run, to reproduce run on the current master:output-report: jsonto the config file--dump-shardsFileNotFounderrorTest Plan
output-report: jsonto the config file--dump-shardsChecklist