Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Return directories path in Flank Github action #1675

Merged
merged 3 commits into from
Mar 11, 2021
Merged

feat: Return directories path in Flank Github action #1675

merged 3 commits into from
Mar 11, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Mar 10, 2021 •
edited
Loading

Fixes #1599

Test Plan

How do we know the code works?

Flank

Stores output path and gcloud path in file flank-links.log

Github action

Returns local and gcloud path after running flank.

Checklist

  • Test repository updated
  • Output variables returned

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2021 •
edited
Loading

Timestamp: 2021-03-11 10:41:11
Buildscan url for ubuntu-workflow run 642470320
https://gradle.com/s/4xpsujqmvca7i

@piotradamczyk5 piotradamczyk5 marked this pull request as draft March 10, 2021 13:37
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review March 10, 2021 17:58
@bootstraponline bootstraponline force-pushed the #1599_return_directories_path branch from e83ac54 to 50d3090 Compare March 10, 2021 17:59
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) March 10, 2021 18:13
@bootstraponline bootstraponline force-pushed the #1599_return_directories_path branch from 50888ab to f269528 Compare March 10, 2021 22:40
@bootstraponline bootstraponline force-pushed the #1599_return_directories_path branch from f269528 to d8e7137 Compare March 11, 2021 05:54
Sloox
Sloox approved these changes Mar 11, 2021
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@piotradamczyk5 piotradamczyk5 merged commit f9e25c9 into master Mar 11, 2021
@piotradamczyk5 piotradamczyk5 deleted the #1599_return_directories_path branch March 11, 2021 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@Sloox Sloox Sloox approved these changes

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

Assignees

@adamfilipow92 adamfilipow92

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass output report as a result of Flank Github action
4 participants
@piotradamczyk5 @Sloox @pawelpasterz @adamfilipow92