feat: Run Flank Github action with config provided by user #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
bootstraponline,
Sloox,
zuziaka,
pawelpasterz and
jan-goral
piotradamczyk5
changed the title
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
piotradamczyk5
changed the title
bootstraponline
force-pushed
the
#1598_added_reading_config_file
branch
from
d75d21c to
47dea64
Compare
|
Timestamp: 2021-03-09 17:22:30 |
bootstraponline
force-pushed
the
#1598_added_reading_config_file
branch
from
47dea64 to
6f06bb2
Compare
piotradamczyk5
force-pushed
the
#1598_added_reading_config_file
branch
from
6f06bb2 to
810cac1
Compare
pawelpasterz
approved these changes
Mar 10, 2021
Sloox
approved these changes
Mar 10, 2021
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Download flankScripts | ||
| run: | | ||
| curl -L https://github.com/Flank/flank/releases/download/flank-scripts-1.9.0/flank-scripts.jar --output flank-scripts.jar | ||
| curl -L https://github.com/Flank/flank/releases/download/flank-scripts-1.9.1/flank-scripts.jar --output flank-scripts.jar |
There was a problem hiding this comment.
is there a possibility to always retrieve the latest?
Therefore we dont need to constantly change the version number?
There was a problem hiding this comment.
@Sloox
It is by design because we are sure that we will use a stable version tested with this Github action
Sloox
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1598
Test Plan
Flank Github action works properly 🎉
Please see the test repository for running examples
Checklist