feat: Added reading service account in Github action #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Timestamp: 2021-03-09 08:02:27 |
piotradamczyk5
commented
Mar 8, 2021
piotradamczyk5
commented
Mar 8, 2021
piotradamczyk5
force-pushed
the
#1597-set-service-account-in-action
branch
2 times, most recently
from
f76520d to
d63e335
Compare
piotradamczyk5
requested review from
pawelpasterz,
Sloox,
zuziaka,
bootstraponline and
jan-goral
piotradamczyk5
force-pushed
the
#1597-set-service-account-in-action
branch
from
d63e335 to
0a06186
Compare
Sloox
approved these changes
Mar 8, 2021
pawelpasterz
reviewed
Mar 9, 2021
flank-scripts/src/main/kotlin/flank/scripts/ops/firebase/SaveServiceAccount.kt
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/cli/firebase/SaveServiceAccountCommand.kt
Show resolved
Hide resolved
pawelpasterz
approved these changes
Mar 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1597
Test Plan
Flank scripts part
Run command
flankScripts firebase save_service_account --account=<file content, link, file path>-> to test storing service accountGithub action part
You could run Flank GitHub action on testing repository
Checklist