Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix NPE in GcToolResults #1662

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix: Fix NPE in GcToolResults #1662

merged 1 commit into from
Mar 5, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1649

PR adds NPE handling when fetching results

Test Plan

How do we know the code works?

  1. build workflows finish with success
  2. IT pass

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/rdavqfbv6i4ke
Linux Build scan: https://gradle.com/s/pwnahsaqa2ckk
Workflow run https://github.com/Flank/flank/actions/runs/623910795

@mergify
Copy link

mergify bot commented Mar 5, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@pawelpasterz pawelpasterz changed the title tetst: Fix NPE in GcToolResults test: Fix NPE in GcToolResults Mar 5, 2021
@pawelpasterz pawelpasterz changed the title test: Fix NPE in GcToolResults fix: Fix NPE in GcToolResults Mar 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

Timestamp: 2021-03-05 09:11:38
Buildscan url for ubuntu-workflow run 623909982
https://gradle.com/s/uwlabrcxmyava

@mergify mergify bot merged commit fe72d53 into master Mar 5, 2021
@mergify mergify bot deleted the 1649-follow-up-fix-npe branch March 5, 2021 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants