test: Implement logic to clear LocalGcs after each test #1661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1578
Change description:
ArgsHelperTest#assertGcsFileExists succeeds
&TestRunnerTest#mockedAndroidTestRun gcsAndHistoryName
)FakeStorageRpc
which is created withLocalStorageHelper.getOptions()
FakeStorageRpc
can be cleaned/reseted only by callingLocalStorageHelper.getOptions()
(both its hashmaps are cleared)FakeStorageRpc
-- storage hasreset
method but it's not exposedTestStorageProvider
is introduced to wrap additional test logicTestStorageProvider
isGcStorage
should not be aware of how it is used (tests or production )TestStorageProvider
has nullableStorage
filed. It can be cleared (set null) with#clearStorage
TestStorageProvider
will invokeLocalStorageHelper.getOptions()
and assign reference to storage field.FlankTestRunner
has a custom listener that will invokeLocalGcs#clear()
after each test runTest Plan
Unfortunately, there is no straightforward way to verify it since OOM error occurred only on GH Actions machines, randomly.