Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Flank GitHub action #1660

Merged
merged 27 commits into from
Mar 5, 2021
Merged

feat: Add Flank GitHub action #1660

merged 27 commits into from
Mar 5, 2021

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Mar 4, 2021 •
edited
Loading

Fixes #1596

Test Plan

How do we know the code works?

Flank scripts part

Run command

  • flankScripts github download_flank -> to get latest version
  • flankScripts github download_flank <version> -> to get specified version

Github action part

You could run Flank GitHub action on testing repository

Checklist

  • Documented
  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

piotradamczyk5
piotradamczyk5 commented Mar 4, 2021
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Mar 4, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@piotradamczyk5 piotradamczyk5 marked this pull request as draft March 4, 2021 16:41
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021 •
edited
Loading

Timestamp: 2021-03-05 14:54:06
Buildscan url for ubuntu-workflow run 624754156
https://gradle.com/s/4o24zem2p7dag

@piotradamczyk5 piotradamczyk5 changed the title #1596 add flank GitHub action feat: Add Flank GitHub action Mar 4, 2021
@piotradamczyk5 piotradamczyk5 force-pushed the #1596-add-flank-github-action branch from defe37f to 0c512cb Compare March 4, 2021 16:49
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review March 4, 2021 16:49
pawelpasterz
pawelpasterz reviewed Mar 5, 2021
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@bootstraponline bootstraponline force-pushed the #1596-add-flank-github-action branch 2 times, most recently from 0e573a2 to 317fdf1 Compare March 5, 2021 13:29
@bootstraponline bootstraponline force-pushed the #1596-add-flank-github-action branch from 317fdf1 to d058d0f Compare March 5, 2021 13:42
Piotr Adamczyk added 2 commits March 5, 2021 15:41
Merge remote-tracking branch 'origin/#1596-add-flank-github-action' i…
1c47e50 
…nto #1596-add-flank-github-action

# Conflicts:
#	action.yml
#	flank-scripts/src/main/kotlin/flank/scripts/ops/github/DownloadFlank.kt
fix tests
b99d753
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) March 5, 2021 14:54
@piotradamczyk5 piotradamczyk5 merged commit 8ee557b into master Mar 5, 2021
@piotradamczyk5 piotradamczyk5 deleted the #1596-add-flank-github-action branch March 5, 2021 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@Sloox Sloox Sloox approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@adamfilipow92 adamfilipow92

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download Flank in Github Action
4 participants
@piotradamczyk5 @Sloox @pawelpasterz @adamfilipow92