Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove physical device from integration tests #1657

Merged
merged 1 commit into from
Mar 4, 2021
Merged

fix: Remove physical device from integration tests #1657

merged 1 commit into from
Mar 4, 2021

Conversation

adamfilipow92
Copy link
Contributor

Fixes #1632

Test Plan

How do we know the code works?

IT should pass.

Checklist

  • Integration tests updated

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bootstraponline bootstraponline force-pushed the 1632-remove-physical-devices-from-it branch from d9cd8bb to 77c3879 Compare March 3, 2021 15:13
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021 •
edited
Loading

Timestamp: 2021-03-03 17:49:03
Buildscan url for ubuntu-workflow run 618405917
https://gradle.com/s/bww3u5hpznd54

@piotradamczyk5
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/wzwk3jwhuxdlm
Linux status failure - Build scan: https://gradle.com/s/q7anplc2ufhxm
Workflow run https://github.com/Flank/flank/actions/runs/618022257

@bootstraponline bootstraponline force-pushed the 1632-remove-physical-devices-from-it branch from 77c3879 to e260a4f Compare March 3, 2021 15:51
@bootstraponline bootstraponline force-pushed the 1632-remove-physical-devices-from-it branch from e260a4f to 04b2a29 Compare March 3, 2021 17:43
@piotradamczyk5 piotradamczyk5 self-requested a review March 3, 2021 18:14
@piotradamczyk5
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/tye5itsejtzk2
Linux status failure - Build scan: https://gradle.com/s/3rqboultxz3m6
Workflow run https://github.com/Flank/flank/actions/runs/620284080

@mergify mergify bot merged commit 9957136 into master Mar 4, 2021
@Sloox Sloox self-requested a review March 4, 2021 11:17
@mergify mergify bot deleted the 1632-remove-physical-devices-from-it branch March 4, 2021 11:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@Sloox Sloox Awaiting requested review from Sloox

Assignees

@adamfilipow92 adamfilipow92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove physical devices (android) from IT configs
3 participants
@adamfilipow92 @piotradamczyk5 @Sloox