Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Change packages of commands #1651

Merged
merged 1 commit into from
Mar 3, 2021
Merged

refactor: Change packages of commands #1651

merged 1 commit into from
Mar 3, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1637

Test Plan

How do we know the code works?

Flank works as previously

Checklist

  • iOS commands moved
  • Android commands moved

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021 •
edited
Loading

Timestamp: 2021-03-03 14:43:47
Buildscan url for ubuntu-workflow run 617869927
https://gradle.com/s/idkrnyudmd57i

@piotradamczyk5 piotradamczyk5 changed the title refactor: Change packages of command refactor: Change packages of commands Mar 2, 2021
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) March 2, 2021 17:17
@bootstraponline bootstraponline force-pushed the #1637-move-commands branch 2 times, most recently from 7b5bfbd to 5db371d Compare March 3, 2021 13:14
adamfilipow92
adamfilipow92 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tests pass
  • Code looks good

@piotradamczyk5 piotradamczyk5 merged commit a5ca7a3 into master Mar 3, 2021
@piotradamczyk5 piotradamczyk5 deleted the #1637-move-commands branch March 3, 2021 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@Sloox Sloox Sloox approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move commands to correct package
3 participants
@piotradamczyk5 @Sloox @adamfilipow92