-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Explore test-targets-for-shards SDD #1627
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Title does not follow the guidelines of Conventional Commits.
|
46e813e
to
230d713
Compare
Timestamp: 2021-02-26 17:54:20 |
docs/feature/1532-explore-test-target-for-shards-with-extra-features.md
Outdated
Show resolved
Hide resolved
docs/feature/1532-explore-test-target-for-shards-with-extra-features.md
Outdated
Show resolved
Hide resolved
docs/feature/1532-explore-test-target-for-shards-with-extra-features.md
Outdated
Show resolved
Hide resolved
docs/feature/1532-explore-test-target-for-shards-with-extra-features.md
Outdated
Show resolved
Hide resolved
docs/feature/1532-explore-test-target-for-shards-with-extra-features.md
Outdated
Show resolved
Hide resolved
docs/feature/1532-explore-test-target-for-shards-with-extra-features.md
Outdated
Show resolved
Hide resolved
docs/feature/1532-explore-test-target-for-shards-with-extra-features.md
Outdated
Show resolved
Hide resolved
docs/feature/1532-explore-test-target-for-shards-with-extra-features.md
Outdated
Show resolved
Hide resolved
@Sloox @pawelpasterz @adamfilipow92 @bootstraponline @jan-gogo @axelzuziak-gogo |
a8fa797
to
00f3d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely, test-targets-for-shard
should remain as it is now 👌
I think the only way to implement it is with the additional configuration on the flank level (as you proposed). plan-sharding
, smart-test-targets-for-shards
both have fine names for me.
Fladle gives flexibility when it comes to multiple configurations. Yet, that feature would allow us to run it within a single test run. So it comes to the question about business value 🤷♂️
And another config options to the already big one 😅
00f3d5b
to
2970323
Compare
We will not implement this feature for now, but let's merge this SDD to make it available for future |
…atures.md Co-authored-by: Michael Wright <[email protected]>
…atures.md Co-authored-by: Michael Wright <[email protected]>
…atures.md Co-authored-by: Michael Wright <[email protected]>
…atures.md Co-authored-by: Michael Wright <[email protected]>
…atures.md Co-authored-by: Michael Wright <[email protected]>
…atures.md Co-authored-by: Michael Wright <[email protected]>
…atures.md Co-authored-by: Michael Wright <[email protected]>
…atures.md Co-authored-by: Michael Wright <[email protected]>
2970323
to
b12e6c2
Compare
Fixes #1532
Test Plan
This is SDD
Checklist