Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explore test-targets-for-shards SDD #1627

Merged
merged 9 commits into from
Feb 26, 2021

Conversation

piotradamczyk5
Copy link
Contributor

Fixes #1532

Test Plan

How do we know the code works?

This is SDD

Checklist

  • Researched
  • SDD
  • Follow up tasks created

@piotradamczyk5 piotradamczyk5 added the Documentation Pull request which touches documentation label Feb 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mergify
Copy link

mergify bot commented Feb 23, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@bootstraponline bootstraponline force-pushed the #1532-explore_test-target-for-shards branch from 46e813e to 230d713 Compare February 23, 2021 17:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2021

Timestamp: 2021-02-26 17:54:20
Buildscan url for ubuntu-workflow run 603525923
https://gradle.com/s/bc6epciypvapi

@piotradamczyk5
Copy link
Contributor Author

@Sloox @pawelpasterz @adamfilipow92 @bootstraponline @jan-gogo @axelzuziak-gogo
Do you think that we need this feature?

@bootstraponline bootstraponline force-pushed the #1532-explore_test-target-for-shards branch from a8fa797 to 00f3d5b Compare February 24, 2021 16:49
Copy link
Contributor

@pawelpasterz pawelpasterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, test-targets-for-shard should remain as it is now 👌

I think the only way to implement it is with the additional configuration on the flank level (as you proposed). plan-sharding, smart-test-targets-for-shards both have fine names for me.

Fladle gives flexibility when it comes to multiple configurations. Yet, that feature would allow us to run it within a single test run. So it comes to the question about business value 🤷‍♂️

And another config options to the already big one 😅

@bootstraponline bootstraponline force-pushed the #1532-explore_test-target-for-shards branch from 00f3d5b to 2970323 Compare February 25, 2021 11:54
@Sloox Sloox self-requested a review February 25, 2021 13:02
@piotradamczyk5
Copy link
Contributor Author

@piotradamczyk5
Copy link
Contributor Author

We will not implement this feature for now, but let's merge this SDD to make it available for future

@bootstraponline bootstraponline force-pushed the #1532-explore_test-target-for-shards branch from 2970323 to b12e6c2 Compare February 26, 2021 17:46
@mergify mergify bot merged commit 2584eeb into master Feb 26, 2021
@mergify mergify bot deleted the #1532-explore_test-target-for-shards branch February 26, 2021 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Pull request which touches documentation Feature Research Tiger 🐯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore test-target-for-shards with extra features
3 participants