Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Corellium sandbox #1621

Merged
merged 16 commits into from
Mar 10, 2021
Merged

docs: Corellium sandbox #1621

merged 16 commits into from
Mar 10, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Feb 21, 2021 •
edited
Loading

This PR introduces naive corellium client implementation + sandbox with an example script.
There is lots of kotlin code, yet it's not the main purpose of this task, just keep it in mind during the review 😅

All necessary info is included in documentation MD files:

Actions:

  • Login
  • Get Project Ids
  • Get Project info
  • Get Instances
  • Get Instance info
  • Create Instance
  • Upload file
  • Get VPN config
  • properties file
  • Retry mechanism
  • Configurable logging
  • Documentation -- client
  • Documentation -- sandbox
  • Documentation -- summary
  • Run script

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2021 •
edited
Loading

Timestamp: 2021-03-10 13:52:34
Buildscan url for ubuntu-workflow run 639458889
https://gradle.com/s/x3frkgxyhfguw

@pawelpasterz pawelpasterz self-assigned this Feb 22, 2021
@pawelpasterz pawelpasterz force-pushed the 1607-corellium-playground branch 2 times, most recently from 17bacbd to 1b49dfe Compare February 25, 2021 12:03
@pawelpasterz pawelpasterz marked this pull request as ready for review February 26, 2021 13:50
@pawelpasterz pawelpasterz changed the title Corellium sandbox doc: Corellium sandbox Feb 26, 2021
@bootstraponline bootstraponline force-pushed the 1607-corellium-playground branch from 68e89c8 to f1ff0fe Compare February 26, 2021 17:47
@mergify
Copy link

mergify bot commented Feb 26, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@pawelpasterz pawelpasterz changed the title doc: Corellium sandbox docs: Corellium sandbox Feb 26, 2021
@bootstraponline bootstraponline force-pushed the 1607-corellium-playground branch from f1ff0fe to 5eea7ae Compare February 26, 2021 17:57
@pawelpasterz
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link

mergify bot commented Mar 1, 2021

Command refresh: success

Pull request refreshed

@bootstraponline bootstraponline force-pushed the 1607-corellium-playground branch from 5eea7ae to 6e4bc0e Compare March 1, 2021 11:46
@pawelpasterz
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Mar 2, 2021

Command rebase: success

Branch has been successfully rebased

@bootstraponline bootstraponline force-pushed the 1607-corellium-playground branch from 6e4bc0e to e983d7c Compare March 2, 2021 06:53
@pawelpasterz
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Mar 3, 2021

Command rebase: success

Branch has been successfully rebased

@bootstraponline bootstraponline force-pushed the 1607-corellium-playground branch from e983d7c to 87a01a5 Compare March 3, 2021 05:49
@pawelpasterz
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Mar 3, 2021

Command rebase: success

Branch has been successfully rebased

@bootstraponline bootstraponline force-pushed the 1607-corellium-playground branch from 63311de to 21df361 Compare March 3, 2021 13:37
@bootstraponline bootstraponline force-pushed the 1607-corellium-playground branch from 02e7daf to 542497b Compare March 8, 2021 11:58
@mergify
Copy link

mergify bot commented Mar 8, 2021

Command rebase: success

Branch has been successfully rebased

Sloox
Sloox suggested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawelpasterz is this reviewable or are we shelving this until further notice?

@pawelpasterz
Copy link
Contributor Author

@pawelpasterz is this reviewable or are we shelving this until further notice?

Yes, please review! I want finally close this PR :)

I suppose you might have similar questions as Pitor had, please check #1621 (comment) (and older comments if you like)

@Sloox Sloox self-requested a review March 10, 2021 13:04
Sloox
Sloox approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments

@pawelpasterz
Copy link
Contributor Author

@Mergifyio rebase

@pawelpasterz pawelpasterz enabled auto-merge (squash) March 10, 2021 13:46
@mergify
Copy link

mergify bot commented Mar 10, 2021

Command rebase: success

Branch has been successfully rebased

@bootstraponline bootstraponline force-pushed the 1607-corellium-playground branch from 5304bf5 to 4b6752e Compare March 10, 2021 13:47
@pawelpasterz pawelpasterz merged commit ca003ea into master Mar 10, 2021
@pawelpasterz pawelpasterz deleted the 1607-corellium-playground branch March 10, 2021 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
@jan-goral jan-goral linked an issue Mar 11, 2021 that may be closed by this pull request
Corellium API playground SDD #1607
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@pawelpasterz pawelpasterz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Corellium API playground SDD
3 participants
@pawelpasterz @piotradamczyk5 @Sloox