-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NPE on dumpShards #1612
fix: NPE on dumpShards #1612
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Timestamp: 2021-02-17 23:35:14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be great to cover more cases within tests. For JSON verification, I think we should verify if ignored tests are present in the right place but also if the number of shards is correct. We should also check if the total number of tests is correct
integration_tests/src/test/resources/cases/dump_shards_android.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: pawelpasterz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has it been tested on Windows ;)
Tested and works :) |
) | ||
|
||
Truth.assertThat(matrix.junitIgnored.count()).isEqualTo(4) | ||
Truth.assertThat(matrix.junitIgnored).containsNoDuplicates() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! 👍
Truth.assertThat(matrix.shards.values.flatten()).containsAll( | ||
"class com.example.test_app.parametrized.EspressoParametrizedClassParameterizedNamed", | ||
"class com.example.test_app.parametrized.EspressoParametrizedClassTestParameterized", | ||
"class com.example.test_app.ParameterizedTest", | ||
"class com.example.test_app.parametrized.EspressoParametrizedMethodTestJUnitParamsRunner", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the test checks if there are tests inside shards 👍 We could make one step further and check if there are all tests or we can check just the number. (test count does not change and we check for duplication in another line)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #1601
Test Plan
When use
--dump-shards
, flank should create dump shard file without errors.Checklist