Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix IT workflow for windows #1560

Merged
merged 6 commits into from
Feb 3, 2021
Merged

fix: Fix IT workflow for windows #1560

merged 6 commits into from
Feb 3, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Feb 3, 2021

Fixes #

Test Plan

How do we know the code works?
Can only be tested once its merged due to IT structure.

@Sloox Sloox self-assigned this Feb 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Sloox Sloox requested a review from piotradamczyk5 February 3, 2021 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021 •
edited
Loading

Timestamp: 2021-02-03 16:40:44
Buildscan url for ubuntu-workflow run 534489237
https://gradle.com/s/wr2uj2gwor7r2

@piotradamczyk5
Copy link
Contributor

I guess that PR title should be also changed

@Sloox Sloox changed the title fix: Add needed env variables for windows to run on the cloud fix: Fix IT workflow for windows Feb 3, 2021
@Sloox Sloox enabled auto-merge (squash) February 3, 2021 16:36
@Sloox Sloox merged commit a007f6c into master Feb 3, 2021
@Sloox Sloox deleted the #1551-windows-IT-fixes branch February 3, 2021 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@jan-goral jan-goral jan-goral approved these changes

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

Assignees

@Sloox Sloox

Labels
Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sloox @piotradamczyk5 @bootstraponline @jan-goral @adamfilipow92