Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix flaky FilesTest #1546

Merged
merged 2 commits into from
Jan 29, 2021
Merged

fix: Fix flaky FilesTest #1546

merged 2 commits into from
Jan 29, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Jan 29, 2021 •
edited
Loading

What was done?

  • remove Should download file and store it and destination test (it tests downloadFile which is actually a wrapper for fuel's download functionality)
  • use TemporaryFolder

Test Plan

How do we know the code works?

All workflows should finish without any error (especially ubuntu-workflow)

@pawelpasterz pawelpasterz self-assigned this Jan 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2021 •
edited
Loading

Timestamp: 2021-01-29 11:48:29
Buildscan url for ubuntu-workflow run 520610138

@Sloox Sloox self-requested a review January 29, 2021 08:28
Sloox
Sloox previously requested changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawelpasterz lets remove this test as discussed.

@pawelpasterz pawelpasterz marked this pull request as draft January 29, 2021 09:05
@pawelpasterz pawelpasterz marked this pull request as ready for review January 29, 2021 09:18
@pawelpasterz pawelpasterz requested a review from Sloox January 29, 2021 09:18
@mergify mergify bot merged commit cb51bfd into master Jan 29, 2021
@mergify mergify bot deleted the fix-flaky-files-test branch January 29, 2021 12:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@jan-goral jan-goral jan-goral approved these changes

@zuziaka zuziaka zuziaka approved these changes

@Sloox Sloox Awaiting requested review from Sloox

Assignees

@pawelpasterz pawelpasterz

Labels
Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pawelpasterz @Sloox @zuziaka @jan-goral @piotradamczyk5