Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Windows integration test #1535

Merged
merged 3 commits into from
Jan 27, 2021
Merged

ci: Windows integration test #1535

merged 3 commits into from
Jan 27, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Jan 26, 2021

Fixes #1527

Test Plan

How do we know the code works?
Run @flank-it to see if it passes succesfully
.

Checklist

  • Integration tests updated

@Sloox Sloox requested a review from piotradamczyk5 January 26, 2021 10:40
@Sloox Sloox self-assigned this Jan 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2021 •
edited
Loading

Timestamp: 2021-01-26 14:13:57
Buildscan url for ubuntu-workflow run 512325306
https://gradle.com/s/uvmprcblt2dp6

@Sloox
Copy link
Contributor Author

Sloox commented Jan 26, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2021 •
edited
Loading

Integration tests succeed ✅
Build scan https://gradle.com/s/ypclnp7k7ipdq
Workflow run https://github.com/Flank/flank/actions/runs/511979409

@Sloox
Copy link
Contributor Author

Sloox commented Jan 26, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2021 •
edited
Loading

Integration tests succeed ✅
Build scan https://gradle.com/s/kcuhd2t47vzbc
Workflow run https://github.com/Flank/flank/actions/runs/512086911

@Sloox
Copy link
Contributor Author

Sloox commented Jan 26, 2021

@flank-it

@Sloox Sloox marked this pull request as ready for review January 26, 2021 14:09
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2021 •
edited
Loading

Integration tests succeed ✅
Build scan https://gradle.com/s/t2v63qctz2cri
Workflow run https://github.com/Flank/flank/actions/runs/512328307

@Sloox
Copy link
Contributor Author

Sloox commented Jan 26, 2021

@piotradamczyk5 and I discussed that it needs to merged in to actually confirm that it works successfully

adamfilipow92
adamfilipow92 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pawelpasterz pawelpasterz merged commit 6f47461 into master Jan 27, 2021
@pawelpasterz pawelpasterz deleted the #1527-windows-integration branch January 27, 2021 07:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@Sloox Sloox

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-introduce integration tests for windows
4 participants
@Sloox @adamfilipow92 @piotradamczyk5 @pawelpasterz