Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Windows Integration tests #1526

Merged
merged 1 commit into from
Jan 22, 2021
Merged

fix: Windows Integration tests #1526

merged 1 commit into from
Jan 22, 2021

Conversation

Sloox
Copy link
Contributor

@Sloox Sloox commented Jan 22, 2021 •
edited by adamfilipow92
Loading

Fixes #1522

Test Plan

How do we know the code works?
Integration tests work

Checklist

  • Integration tests updated

@Sloox Sloox added the Bug label Jan 22, 2021
@Sloox Sloox requested a review from adamfilipow92 January 22, 2021 14:00
@Sloox Sloox self-assigned this Jan 22, 2021
@github-actions
Copy link
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Sloox
Copy link
Contributor Author

Sloox commented Jan 22, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2021 •
edited
Loading

Integration tests succeed ✅
Build scan
Workflow run https://github.com/Flank/flank/actions/runs/503817398

@github-actions
Copy link
Contributor

Timestamp: 2021-01-22 14:06:01
Buildscan url for ubuntu-workflow run 503814396
https://gradle.com/s/fha7a7h37ncpq

adamfilipow92
adamfilipow92 reviewed Jan 22, 2021
View reviewed changes
integration_tests/src/test/kotlin/integration/GameloopIT.kt
@@ -32,6 +34,7 @@ class GameloopIT {

@Test
fun iosGameloop() {
assumeFalse(isWindows)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamfilipow92 it causes way too much conflicts. Technically it can atleast run it on windows. But the return and errors coming back make it a pain to fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And after thinking about it. Most people working with IOS applications will not be attempting to have them running on windows.

@Sloox Sloox requested a review from adamfilipow92 January 22, 2021 15:17
@Sloox Sloox removed the Feature label Jan 22, 2021
adamfilipow92
adamfilipow92 approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 4f2bb6f into master Jan 22, 2021
@mergify mergify bot deleted the windows_integration_test branch January 22, 2021 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

@zuziaka zuziaka Awaiting requested review from zuziaka

Assignees

@Sloox Sloox

Labels
Bug Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GameLoop IntegrationTests
3 participants
@Sloox @adamfilipow92 @piotradamczyk5