Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update compare file and make url option not required #1514

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1508

Removes unnecessary regex in multiple apk compare file. Make process result command resistant for missing --url option

Test Plan

How do we know the code works?

  1. ./gradlew build
  2. All tests pass
  3. Run
    java -jar ./flank-scripts/build/libs/flank-scripts.jar integration processResults \
      --result=failure \
      --url=  \
      --github-token=[actually can be anything] \
      --run-id=123456
    
  4. Observe output in console contains:
    ** Parameters:
     result: FAILURE
     url:    No build scan URL provided
     runID:  123456
    
  5. You can also verify if a comment is posted properly. To do it, update your flank-debug.properties with your repo and run 3) with the correct gh token.
  6. In the newly created issue No build scan URL provided should be present in a comment

Checklist

  • Unit tested
  • Integration tests updated

@pawelpasterz pawelpasterz self-assigned this Jan 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mergify
Copy link

mergify bot commented Jan 20, 2021

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@github-actions github-actions bot added the Bug label Jan 20, 2021
@pawelpasterz pawelpasterz changed the title Update compare file and make url option not required test: Update compare file and make url option not required Jan 20, 2021
@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2021

Integration tests failed ❌
Build scan https://gradle.com/s/3zlbysqnkxike
Workflow run https://github.com/Flank/flank/actions/runs/498471373

@piotradamczyk5 piotradamczyk5 self-requested a review January 20, 2021 13:42
@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2021

Integration tests failed ❌
Build scan https://gradle.com/s/hg2wqyatzdufy
Workflow run https://github.com/Flank/flank/actions/runs/499140950

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2021

Timestamp: 2021-01-21 15:05:40
Buildscan url for ubuntu-workflow run 501409745
https://gradle.com/s/so4wlawxyimks

@pawelpasterz
Copy link
Contributor Author

Should be retested and merged after #1521

@piotradamczyk5
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2021

Integration tests failed ❌
Build scan https://gradle.com/s/bg3pg7haq56bg
Workflow run https://github.com/Flank/flank/actions/runs/500409936

@pawelpasterz
Copy link
Contributor Author

IT failing due to quota limit exceeded...

@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2021

Integration tests succeed ✅
Build scan https://gradle.com/s/wrqeqoyqw5xhu
Workflow run https://github.com/Flank/flank/actions/runs/501068482

@jan-goral
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2021

Integration tests succeed ✅
Build scan
Workflow run https://github.com/Flank/flank/actions/runs/501240212

@jan-goral
Copy link
Contributor

jan-goral commented Jan 21, 2021

I have run flank-it once more. If the PR is fixing IT flakiness the tests should pass at least twice in a row.

[Edit]
Upss I forgot about quota limits.

Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks good
  • Integration tests works

@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) January 21, 2021 15:01
@piotradamczyk5 piotradamczyk5 merged commit fb44f61 into master Jan 21, 2021
@piotradamczyk5 piotradamczyk5 deleted the 1508-IT-enhancements branch January 21, 2021 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IT are flaky
4 participants