-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update compare file and make url option not required #1514
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Title does not follow the guidelines of Conventional Commits.
|
@flank-it |
Integration tests failed ❌ |
b3bddd7
to
7e8fa08
Compare
@flank-it |
Integration tests failed ❌ |
Timestamp: 2021-01-21 15:05:40 |
Should be retested and merged after #1521 |
@flank-it |
Integration tests failed ❌ |
3792c8e
to
a44daf2
Compare
IT failing due to quota limit exceeded... |
@flank-it |
Integration tests succeed ✅ |
@flank-it |
Integration tests succeed ✅ |
I have run flank-it once more. If the PR is fixing IT flakiness the tests should pass at least twice in a row. [Edit] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks good
- Integration tests works
Fixes #1508
Removes unnecessary regex in multiple apk compare file. Make process result command resistant for missing
--url
optionTest Plan
./gradlew build
flank-debug.properties
with your repo and run 3) with the correct gh token.No build scan URL provided
should be present in a commentChecklist