fix: Resolve Fails on Windows #1470

Sloox · 2021-01-07T14:52:59Z

Test Plan

How do we know the code works?
Simple solution. Increases space used but works without process elevation.
works on Pro + Home.

github-actions · 2021-01-07T14:53:15Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Sloox · 2021-01-07T15:07:16Z

I have read the CLA Document and I hereby sign the CLA

Sloox · 2021-01-07T15:07:30Z

recheck

Sloox · 2021-01-07T15:10:41Z

@flank-it

github-actions · 2021-01-07T15:12:09Z

Integration tests succeed ✅
Build scan
Workflow run https://github.com/Flank/flank/actions/runs/469213124

github-actions · 2021-01-07T15:17:43Z

Timestamp: 2021-01-12 05:07:07
Buildscan url for ubuntu-workflow run 479396836
https://gradle.com/s/q5w6utsb24itc

common/src/main/kotlin/flank/common/Files.kt

mergify · 2021-01-08T14:37:40Z

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

build - Changes that affect the build system or external dependencies (dependencies update)
ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
docs - Documentation only changes
feat - A new feature
fix - A bug fix
chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
refactor - A code change that contains refactor
style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
test - Adding missing tests or correcting existing tests and also changes for our test app
perf - A code change that improves performance (I do not think we will use it)

adamfilipow92 · 2021-01-11T05:24:46Z

I try to test your solution but when I try to build Flank I get

Execution failed for task ':flank-scripts:checkIfVersionUpdated'.
> Flank scripts version is not updated, but files changed.
  Please update version according to schema: <breaking change>.<feature added>.<fix/minor change>

pawelpasterz · 2021-01-11T07:18:46Z

I try to test your solution but when I try to build Flank I get

Execution failed for task ':flank-scripts:checkIfVersionUpdated'.
> Flank scripts version is not updated, but files changed.
  Please update version according to schema: <breaking change>.<feature added>.<fix/minor change>

Hey @adamfilipow92 I've implemented some changes, could you verify again?

adamfilipow92 · 2021-01-11T07:19:45Z

I try to test your solution but when I try to build Flank I get
Execution failed for task ':flank-scripts:checkIfVersionUpdated'.
> Flank scripts version is not updated, but files changed.
  Please update version according to schema: <breaking change>.<feature added>.<fix/minor change>
Hey @adamfilipow92 I've implemented some changes, could you verify again?

Sure!

adamfilipow92 · 2021-01-11T07:59:58Z

I think it's not related to this pr but two tests fail
should create new epic with sub issues && should update existing epic from SDKUpdateTest, outputs looks the same. Maybe we could skip these tests on windows and fix it in another ticket.

should create new epic with sub issues

expected to contain:
    ** Create linked issues
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Create new epic
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue 123 successfully converted to an epic
but was:
    ** Create linked issues
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Create new epic
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue 123 successfully converted to an epic
    
	at flank.scripts.shell.firebase.sdk.SDKUpdateTest$should create new epic with sub issues$1.invokeSuspend(SDKUpdateTest.kt:34)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:32)
	at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:113)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:274)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:84)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at flank.scripts.shell.firebase.sdk.SDKUpdateTest.should create new epic with sub issues(SDKUpdateTest.kt:31)

should update existing epic

expected to contain:
    ** Create linked issues
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Update existing epic
    ** Issues successfully added to the issue 123
but was:
    ** Create linked issues
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Issue created:
         url:    https://bla.org
         number: 123 
    ** Update existing epic
    ** Issues successfully added to the issue 123
    
	at flank.scripts.shell.firebase.sdk.SDKUpdateTest$should update existing epic$1.invokeSuspend(SDKUpdateTest.kt:50)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:32)
	at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:113)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
	at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:32)
	at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:113)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:274)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:84)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at flank.scripts.shell.firebase.sdk.SDKUpdateTest.should update existing epic(SDKUpdateTest.kt:40)

pawelpasterz · 2021-01-11T08:28:57Z

@adamfilipow92 thanks!
Fixed

pawelpasterz · 2021-01-11T08:31:41Z

@flank-it

github-actions · 2021-01-11T08:32:47Z

Integration tests failed ❌
Build scan https://gradle.com/s/7aat66s55e5fg
Workflow run https://github.com/Flank/flank/actions/runs/477077981

pawelpasterz · 2021-01-11T09:36:24Z

@flank-it

github-actions · 2021-01-11T09:37:08Z

Integration tests succeed ✅
Build scan https://gradle.com/s/ckxlwwvn6656k
Workflow run https://github.com/Flank/flank/actions/runs/477192919

.github/workflows/full_suite_integration_tests.yml

adamfilipow92

Works on windows
It passes on windows

Sloox added Bug Tiger 🐯 labels Jan 7, 2021

Sloox requested review from bootstraponline, zuziaka, pawelpasterz, jan-goral, adamfilipow92 and piotradamczyk5 January 7, 2021 14:52

Sloox self-assigned this Jan 7, 2021

github-actions bot added a commit that referenced this pull request Jan 7, 2021

@Sloox has signed the CLA from Pull Request #1470

3726e8d

Sloox marked this pull request as ready for review January 8, 2021 12:05

piotradamczyk5 reviewed Jan 8, 2021

View reviewed changes

common/src/main/kotlin/flank/common/Files.kt Show resolved Hide resolved

Sloox requested a review from piotradamczyk5 January 8, 2021 12:49

piotradamczyk5 reviewed Jan 8, 2021

View reviewed changes

common/src/main/kotlin/flank/common/Files.kt Show resolved Hide resolved

Sloox changed the title ~~bug: Resolve Fails on Windows~~ fix: Resolve Fails on Windows Jan 8, 2021

Sloox requested a review from piotradamczyk5 January 8, 2021 17:07

piotradamczyk5 approved these changes Jan 8, 2021

View reviewed changes

bootstraponline force-pushed the #1434-resolve-fails branch from f7e705c to 304fc4e Compare January 10, 2021 05:54

bootstraponline force-pushed the #1434-resolve-fails branch 3 times, most recently from 34998f6 to ee73ee9 Compare January 11, 2021 07:05

pawelpasterz force-pushed the #1434-resolve-fails branch from 5b5a833 to e3a8010 Compare January 11, 2021 09:36

pawelpasterz self-assigned this Jan 11, 2021

piotradamczyk5 suggested changes Jan 11, 2021

View reviewed changes

.github/workflows/full_suite_integration_tests.yml Outdated Show resolved Hide resolved

piotradamczyk5 approved these changes Jan 11, 2021

View reviewed changes

pawelpasterz force-pushed the #1434-resolve-fails branch from 593c6fe to 8acfd7a Compare January 11, 2021 15:07

Sloox and others added 9 commits January 12, 2021 05:49

Copy files instead of link

b805bc9

Version update + Files modification

8fbaea5

Lint Fix

c15ea16

Cleanup

119f120

added minor tests

4433c7d

added minor tests 2

9a003c2

Implement CR changes

c9755da

Fix tests

33ce91b

Change workflow condition

f08c820

pawelpasterz force-pushed the #1434-resolve-fails branch from 8acfd7a to f08c820 Compare January 12, 2021 04:49

Bump up flank-scripts version

57f3b3f

pawelpasterz force-pushed the #1434-resolve-fails branch from d8ab5b3 to 57f3b3f Compare January 12, 2021 05:01

adamfilipow92 approved these changes Jan 12, 2021

View reviewed changes

pawelpasterz merged commit 662d88c into master Jan 12, 2021

pawelpasterz deleted the #1434-resolve-fails branch January 12, 2021 06:24

github-actions bot locked and limited conversation to collaborators Jan 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Resolve Fails on Windows #1470

fix: Resolve Fails on Windows #1470

Sloox commented Jan 7, 2021

github-actions bot commented Jan 7, 2021 •

edited

Loading

Sloox commented Jan 7, 2021

Sloox commented Jan 7, 2021

Sloox commented Jan 7, 2021

github-actions bot commented Jan 7, 2021 •

edited

Loading

github-actions bot commented Jan 7, 2021 •

edited

Loading

mergify bot commented Jan 8, 2021

adamfilipow92 commented Jan 11, 2021

pawelpasterz commented Jan 11, 2021

adamfilipow92 commented Jan 11, 2021

adamfilipow92 commented Jan 11, 2021 •

edited

Loading

pawelpasterz commented Jan 11, 2021

pawelpasterz commented Jan 11, 2021

github-actions bot commented Jan 11, 2021 •

edited

Loading

pawelpasterz commented Jan 11, 2021

github-actions bot commented Jan 11, 2021 •

edited

Loading

adamfilipow92 left a comment

fix: Resolve Fails on Windows #1470

fix: Resolve Fails on Windows #1470

Conversation

Sloox commented Jan 7, 2021

Test Plan

github-actions bot commented Jan 7, 2021 • edited Loading

Sloox commented Jan 7, 2021

Sloox commented Jan 7, 2021

Sloox commented Jan 7, 2021

github-actions bot commented Jan 7, 2021 • edited Loading

github-actions bot commented Jan 7, 2021 • edited Loading

mergify bot commented Jan 8, 2021

adamfilipow92 commented Jan 11, 2021

pawelpasterz commented Jan 11, 2021

adamfilipow92 commented Jan 11, 2021

adamfilipow92 commented Jan 11, 2021 • edited Loading

pawelpasterz commented Jan 11, 2021

pawelpasterz commented Jan 11, 2021

github-actions bot commented Jan 11, 2021 • edited Loading

pawelpasterz commented Jan 11, 2021

github-actions bot commented Jan 11, 2021 • edited Loading

adamfilipow92 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 7, 2021 •

edited

Loading

github-actions bot commented Jan 7, 2021 •

edited

Loading

github-actions bot commented Jan 7, 2021 •

edited

Loading

adamfilipow92 commented Jan 11, 2021 •

edited

Loading

github-actions bot commented Jan 11, 2021 •

edited

Loading

github-actions bot commented Jan 11, 2021 •

edited

Loading