Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Small changes in flank-scripts module #1432

Merged
merged 2 commits into from
Dec 29, 2020

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1431

No new logic implemented. Unit tests + integration tests should be enough.

@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2020

Integration tests failed, you could see results here

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2020

Timestamp: 2020-12-29 13:25:26
Buildscan url for ubuntu-workflow run 450803430
https://gradle.com/s/ydaeuffijx7ik

Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@pawelpasterz
Copy link
Contributor Author

Integration tests failed, you could see results here

IT failed due to quota limit exceeded 😢

@Sloox
Copy link
Contributor

Sloox commented Dec 29, 2020

@pawelpasterz what exactly does this PR accomplish?

@bootstraponline bootstraponline force-pushed the flank-scripts-small-refactor branch from f20a13e to de36184 Compare December 29, 2020 10:28
@pawelpasterz
Copy link
Contributor Author

pawelpasterz commented Dec 29, 2020

@pawelpasterz what exactly does this PR accomplish?

This is, let's say, a 'refactor' part of #1422. I wanted to avoid PR with a huge scope so I divided my work into 2 PR (the second is not yet created as it depends on that one)

@piotradamczyk5 piotradamczyk5 self-requested a review December 29, 2020 13:18
@bootstraponline bootstraponline force-pushed the flank-scripts-small-refactor branch from e8e1a83 to 7465494 Compare December 29, 2020 13:20
@mergify mergify bot merged commit d181427 into master Dec 29, 2020
@mergify mergify bot deleted the flank-scripts-small-refactor branch December 29, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor flank-scripts to enable new feature implementation
4 participants