-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Small changes in flank-scripts module #1432
Conversation
@flank-it |
Integration tests failed, you could see results here |
Timestamp: 2020-12-29 13:25:26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
IT failed due to quota limit exceeded 😢 |
@pawelpasterz what exactly does this PR accomplish? |
f20a13e
to
de36184
Compare
This is, let's say, a 'refactor' part of #1422. I wanted to avoid PR with a huge scope so I divided my work into 2 PR (the second is not yet created as it depends on that one) |
flank-scripts/src/main/kotlin/flank/scripts/zenhub/ZenHubAPI.kt
Outdated
Show resolved
Hide resolved
e8e1a83
to
7465494
Compare
Fixes #1431
No new logic implemented. Unit tests + integration tests should be enough.