-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Auto update firebase api client #1424
Conversation
Title does not follow the guidelines of Conventional Commits.
|
Timestamp: 2020-12-24 11:40:24 |
@@ -14,9 +14,10 @@ object GenerateJavaClientCommand : CliktCommand(name = "generateJavaClient", hel | |||
override fun run() { | |||
checkIfPipInstalled() | |||
installClientGeneratorIfNeeded() | |||
val apiPath = Paths.get("test_api").toString() | |||
val firebaseApiPath = Paths.get("", "firebase_apis").toString() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is any difference between paths from Paths.get("", "firebase_apis").toString()
and Paths.get("firebase_apis").toString()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, there is not, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you testing the github actions on a fork?
Yes https://github.com/piotradamczyk5/flank/actions/runs/440668950 |
Fixes #1420
Test Plan
Every Monday morning together with dependencies update ( but on separate PR) pull request with google client library update is created.
Under the hood it use commands (python 2.7 required)
so you could test this PR locally with them
Checklist