Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Auto update firebase api client #1424

Merged
merged 4 commits into from
Dec 28, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Dec 23, 2020

Fixes #1420

Test Plan

How do we know the code works?

Every Monday morning together with dependencies update ( but on separate PR) pull request with google client library update is created.

Under the hood it use commands (python 2.7 required)

pip install google-apis-client-generator
flankScripts shell firebase updateApiJson
flankScripts shell firebase generateJavaClient

so you could test this PR locally with them

Checklist

  • Fixed issues with update client
  • Create Github Action to update client

@mergify
Copy link

mergify bot commented Dec 23, 2020

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2020

Timestamp: 2020-12-24 11:40:24
Buildscan url for ubuntu-workflow run 442251085
https://gradle.com/s/f3ojlaozmkmf6

@piotradamczyk5 piotradamczyk5 changed the title #1420 auto update firebase api client ci: Auto update firebase api client Dec 23, 2020
@piotradamczyk5 piotradamczyk5 enabled auto-merge (squash) December 23, 2020 17:48
@@ -14,9 +14,10 @@ object GenerateJavaClientCommand : CliktCommand(name = "generateJavaClient", hel
override fun run() {
checkIfPipInstalled()
installClientGeneratorIfNeeded()
val apiPath = Paths.get("test_api").toString()
val firebaseApiPath = Paths.get("", "firebase_apis").toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is any difference between paths from Paths.get("", "firebase_apis").toString() and Paths.get("firebase_apis").toString()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, there is not, fixed

Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you testing the github actions on a fork?

@piotradamczyk5
Copy link
Contributor Author

Are you testing the github actions on a fork?

Yes https://github.com/piotradamczyk5/flank/actions/runs/440668950
it fails, because I do not have custom scope token on it

@piotradamczyk5 piotradamczyk5 merged commit 6998a75 into master Dec 28, 2020
@piotradamczyk5 piotradamczyk5 deleted the #1420_auto_update_firebase_api_client branch December 28, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Google Client API automatically
4 participants