fix: Fix calculate shards test #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelpasterz
changed the title
pawelpasterz
requested review from
piotradamczyk5,
adamfilipow92,
zuziaka,
jan-goral and
Sloox
bootstraponline
force-pushed
the
fix-test-performance
branch
from
b041e96 to
2070c21
Compare
|
Timestamp: 2020-12-18 11:51:43 |
jan-goral
approved these changes
Dec 18, 2020
1 task
adamfilipow92
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for failing https://scans.gradle.com/s/b76gcx7urgj7e/tests/:test_runner:test/ftl.shard.ShardTest/performance%20calculateShardsByTime#1
Basically,
mockArgsmethod is extremely CPU consuming and its time should not be measured