-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update GH API #1378
ci: Update GH API #1378
Conversation
Timestamp: 2020-12-08 13:38:02 |
flank-scripts/src/main/kotlin/flank/scripts/github/GithubApi.kt
Outdated
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/github/GithubApi.kt
Outdated
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/exceptions/FlankScriptsExceptionMappers.kt
Outdated
Show resolved
Hide resolved
flank-scripts/src/main/kotlin/flank/scripts/exceptions/FlankScriptsExceptionMappers.kt
Outdated
Show resolved
Hide resolved
|
||
@Serializable | ||
enum class IssueState { | ||
@SerialName("open") OPEN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to confirm if the kotlinx serialization is fully compatible with the GSON we are making use of
Else if might result in us changing all the annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they are, not 100% sure though. In flank-scripts
module we do not use GSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw here we are DE serializing with GSON so just want to confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait what? We should not do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sloox could you give an example? I am unable to find
1e288ee
to
b4d5e22
Compare
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
============================================
- Coverage 77.84% 77.82% -0.03%
Complexity 706 706
============================================
Files 245 245
Lines 4713 4713
Branches 904 904
============================================
- Hits 3669 3668 -1
Misses 551 551
- Partials 493 494 +1 |
4129b82
to
03b833d
Compare
03b833d
to
3ad3b94
Compare
3ad3b94
to
36826b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a look for the Serialization compatibility. It appears to be fine as far as I am aware.
Fixes #1377
This PR adds new requests for flank's GH client. Currently not used. Commit was cherry-picked to make future PR (related to flank scripts/IT) smaller
Test Plan
N/A