feat: Add support for "fail fast" feature on FTL #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootstraponline
force-pushed
the
mmark/flank/fastfail
branch
from
b862b21 to
2f7d1bf
Compare
firebase_apis/test_api/src/main/java/com/google/api/services/testing/model/TestMatrix.java
Outdated
Show resolved
Hide resolved
|
Title does not follow the guidelines of Conventional Commits.
|
bootstraponline
changed the title
RainNapper
force-pushed
the
mmark/flank/fastfail
branch
from
2f7d1bf to
4b29e40
Compare
bootstraponline
force-pushed
the
mmark/flank/fastfail
branch
from
4b29e40 to
e87083d
Compare
RainNapper
force-pushed
the
mmark/flank/fastfail
branch
from
e87083d to
b64c64e
Compare
bootstraponline
force-pushed
the
mmark/flank/fastfail
branch
from
b64c64e to
58f4861
Compare
RainNapper
force-pushed
the
mmark/flank/fastfail
branch
from
58f4861 to
c5c029e
Compare
bootstraponline
force-pushed
the
mmark/flank/fastfail
branch
from
c5c029e to
0dddf21
Compare
RainNapper
force-pushed
the
mmark/flank/fastfail
branch
from
0dddf21 to
097eee7
Compare
bootstraponline
force-pushed
the
mmark/flank/fastfail
branch
from
097eee7 to
8dc5f7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
============================================
+ Coverage 77.81% 77.87% +0.05%
- Complexity 705 707 +2
============================================
Files 244 244
Lines 4693 4701 +8
Branches 901 901
============================================
+ Hits 3652 3661 +9
+ Misses 550 549 -1
Partials 491 491 |
| @@ -49,6 +49,7 @@ IosArgs | |||
| type: ${type?.ymlName} | |||
| app: $app | |||
| test-special-entitlements: $testSpecialEntitlements | |||
| fail-fast: $failFast | |||
There was a problem hiding this comment.
It should be added also for Android
There was a problem hiding this comment.
@piotradamczyk5 @RainNapper include it in ICommonArgs .
There was a problem hiding this comment.
I believe this is already in common args? This code is for the toString, which references common args.
| " feature is for latency sensitive workloads."] | ||
| ) | ||
| @set:JsonProperty("fail-fast") | ||
| var failFast: Boolean? by data |
There was a problem hiding this comment.
should be documented in
test_runner/flank.ios.ymltest_runner/flank.ymldocs/index.md
Sloox
suggested changes
Dec 2, 2020
| "storage, the system will replace it with the external storage path prefix for that device. " + | ||
| "For iOS devices these must be absolute paths under /private/var/mobile/Media or /Documents " + | ||
| "of the app under test. If the path is under an app's /Documents, it must be prefixed with the app's bundle id and a colon"] | ||
| "storage to the designated results bucket after the test is complete. For Android devices these must be absolute paths under " + |
There was a problem hiding this comment.
Please ensure the spacing is the same for the rest of the project we have a code style applied and seeing that the text has been modified might imply that your tabs/spacing dont match.
There was a problem hiding this comment.
It doesn't look like all of these descriptions have consistent indentation. That said, I reverted the spacing changes unrelated to the flag for this PR and picked the more common indentation.
There was a problem hiding this comment.
We have detekt rules and hooks to verify it. Ill look into the spacing issue to make sure its working as inteded. Thanks for the headsup.
| @@ -140,7 +140,7 @@ data class CommonGcloudConfig @JsonIgnore constructor( | |||
| split = ",", | |||
| description = [ | |||
| "A list of device-path=file-path pairs that indicate the device paths to push files to the device before " + | |||
| "starting tests, and the paths of files to push."] | |||
| "starting tests, and the paths of files to push."] | |||
test_runner/src/main/kotlin/ftl/config/common/CommonGcloudConfig.kt
Outdated
Show resolved
Hide resolved
| @@ -49,6 +49,7 @@ IosArgs | |||
| type: ${type?.ymlName} | |||
| app: $app | |||
| test-special-entitlements: $testSpecialEntitlements | |||
| fail-fast: $failFast | |||
There was a problem hiding this comment.
@piotradamczyk5 @RainNapper include it in ICommonArgs .
RainNapper
force-pushed
the
mmark/flank/fastfail
branch
from
8dc5f7c to
5dc08fc
Compare
bootstraponline
force-pushed
the
mmark/flank/fastfail
branch
from
5dc08fc to
91a6333
Compare
piotradamczyk5
approved these changes
Dec 3, 2020
pawelpasterz
added
the
New Option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (N/A)
Test Plan
Ran a locally built jar in CI, verified that this flag is behaving as expected.
Checklist
Background
When a matrix hits an infrastructure errors, it is automatically retried. This can cause issues in time sensitive scenarios, as results can take ~5-15m longer to report after an infrastructure error occurs. This PR exposes this flag via the CLI.