-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Publishing and downloading flank scripts #1361
ci: Publishing and downloading flank scripts #1361
Conversation
4a4624a
to
87ba5a2
Compare
dc12d96
to
5fa8d7a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1361 +/- ##
============================================
+ Coverage 77.81% 77.83% +0.02%
Complexity 705 705
============================================
Files 244 244
Lines 4693 4693
Branches 901 901
============================================
+ Hits 3652 3653 +1
Misses 550 550
+ Partials 491 490 -1 |
Timestamp: 2020-12-01 09:10:10 |
flank-scripts/build.gradle.kts
Outdated
pom { | ||
name.set("Flank-scripts") | ||
description.set("Scripts for Flank") | ||
url.set("https://github.com/flank/flank") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Flank/flank
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tested, upload/download works
- Code looks good
Fixes #1347
flank-scripts
is now published to JFrog Bintray [1], so instead of buildingflank-scripts
each time when running some workflow on GitHub actions or when you need it, you could just download it using simple gradle task[2].flank-scripts
support now versioning, so there is a requirement to update its version each time you changed some files insideflank-scripts
directory, otherwise, detekt task will fail[3].Each GitHub actions workflow is updated to download latest version instead of building
flank-scripts
to save time and resources.[4]Test Plan
[1]
gradlew :flank-scripts:bintrayUpload
(bintray account needed)[2]
gradlew :flank-scripts:download
flankScripts.jar
should be downloaded toflank-scripts/bash
[3]
flank-scripts
gradlew check
orgradlew detekt
flank-scripts/build.gradle.kts
gradlew check
orgradlew detekt
[4]
to
Checklist
flank-scripts