Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation about code review by step #1355

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

jan-goral
Copy link
Contributor

This pull request adds a missing page about code review to documentation.

@jan-goral jan-goral added the Documentation Pull request which touches documentation label Nov 26, 2020
@jan-goral jan-goral self-assigned this Nov 26, 2020
@mergify
Copy link

mergify bot commented Nov 26, 2020

Title does not follow the guidelines of Conventional Commits.
Please adjust title before merge and use one of following prefix:

  • build - Changes that affect the build system or external dependencies (dependencies update)
  • ci - Changes to our CI configuration files and scripts (basically directory .github/workflows)
  • docs - Documentation only changes
  • feat - A new feature
  • fix - A bug fix
  • chore - Changes which does not touch the code (ex. manual update of release notes). It will not generate release notes changes
  • refactor - A code change that contains refactor
  • style - Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test - Adding missing tests or correcting existing tests and also changes for our test app
  • perf - A code change that improves performance (I do not think we will use it)

@codecov-io
Copy link

Codecov Report

Merging #1355 (d573cfa) into master (3075194) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1355      +/-   ##
============================================
+ Coverage     77.79%   77.81%   +0.02%     
  Complexity      705      705              
============================================
  Files           244      244              
  Lines          4692     4692              
  Branches        901      901              
============================================
+ Hits           3650     3651       +1     
  Misses          550      550              
+ Partials        492      491       -1     

@github-actions
Copy link
Contributor

Timestamp: 2020-11-26 10:37:01
Buildscan url for ubuntu-workflow run 384308728
https://gradle.com/s/gomeuxrqxslii

@pawelpasterz pawelpasterz changed the title doc: Add documentation about code review by step docs: Add documentation about code review by step Nov 26, 2020
@mergify mergify bot merged commit ac48ceb into master Nov 26, 2020
@mergify mergify bot deleted the code-review-process branch November 26, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Pull request which touches documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants