fix: Downloading performance Metrics

[piotradamczyk5]

Fixes #1324

Test Plan

How do we know the code works?

Scenario A:

1. Run flank on Android physical device. For example with configuration entry:

gcloud:
...
  device:
    - model: OnePlus6T
      version: 28
...

2. Check that performanceMetrics.json is stored on the local results device

Scenario B:

1. Run flank on Android physical device. For example with configuration entry:

gcloud:
...
  device:
    - model: OnePlus6T
      version: 28
...

2. Specify also file to download from GCloud bucket. For example with configuration entry:

flank:
...
  files-to-download:
    - .*\.json$
...

3. Check that performanceMetrics.json is downloaded on the local results device

Checklist

• Save performanceMetrics.json by default to local results directory
• Fix downloading after tests run
• Fix local storage directory structure
• Unit tested

[github-actions]

Timestamp: 2020-11-18 15:51:24
Buildscan url for ubuntu-workflow run 370523557
https://gradle.com/s/smdplwf7y7dfq

[piotradamczyk5]

@Mergifyio rebase

[mergify]

Command rebase: success

Branch already up to date

[adamfilipow92]

This is only cosmetic but i think smth like

    val configFilePath =
        if (args.useLocalResultDir()) Paths.get(args.localResultDir, "performanceMetrics.json")
        else Paths.get(args.localResultDir, resultsDir, "performanceMetrics.json")

is little more readable. WDYT?

[piotradamczyk5]

changed

[adamfilipow92]

So in both scenarios performanceMetrics.json should be downloaded to local storage, right?

[piotradamczyk5]

So in both scenarios performanceMetrics.json should be downloaded to local storage, right?

yes

[adamfilipow92]

• Both scenarios tested
  Great work! 👍

[codecov-io]

Codecov Report

Merging #1326 (fb9b70a) into master (733e444) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master    #1326      +/-   ##
============================================
- Coverage     79.61%   79.58%   -0.04%     
- Complexity      735      736       +1     
============================================
  Files           237      237              
  Lines          4573     4579       +6     
  Branches        792      796       +4     
============================================
+ Hits           3641     3644       +3     
+ Misses          526      525       -1     
- Partials        406      410       +4