Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nested subdirectories in results-dir #1323

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Nov 16, 2020

Fixes #1309

Nested directories are supported out of the box in GCloud results upload.
However Flank has an issue that it throws an exception because it did not properly store results in the local directory.
In order to support nested directories, local issue must be fixed

Test Plan

How do we know the code works?

  1. Set configuration to contains nested result directories usimg results-dir
    ex:
gcloud:
...
  results-dir: nested/results
....
  1. Run tests and see that results are properly updated to GCloud storage and stored locally

Checklist

  • Unit tested

@github-actions
Copy link
Contributor

Timestamp: 2020-11-16 16:10:15
Buildscan url for ubuntu-workflow run 366344257
https://gradle.com/s/jelrjpzitor72

@pawelpasterz
Copy link
Contributor

Please, update the description with more explanatory Test Plan

@pawelpasterz
Copy link
Contributor

I think it would be worth verifying if the subdirectories feature requires additional permissions. If it does, we could display a
suitable message

@piotradamczyk5
Copy link
Contributor Author

Please, update the description with more explanatory Test Plan

done 👍

@piotradamczyk5
Copy link
Contributor Author

I think it would be worth verifying if the subdirectories feature requires additional permissions. If it does, we could display a
suitable message

With current permissions, it works fine so I guess it does not need additional permission

Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested, flank finish without exception
  • Results uploaded properly
    👍

@mergify mergify bot merged commit f02fb4e into master Nov 17, 2020
@mergify mergify bot deleted the #1309_fix_nested_subdirectories branch November 17, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for subdirectories in results-dir
4 participants