ci: Copy properties from issue to pull request #1310

piotradamczyk5 · 2020-11-10T17:04:17Z

Test Plan

How do we know the code works?

When creating pull request labels, assignees and estimates are copied from source issue.
Source issue is discovered by:

Having reference in description (ex. Fixes GitHub action to validate is any user is assigned to pull request #1092)
or
Having reference in branch name(ex. #1092_copy_properties_to_pull_request)

To test it locally use command:
flankScripts pullRequest copyProperties --github-token=<github token> --zenhub-token=<zenhub token, contact me if you would like to test it> --pr-number=<number of PR>

Checklist

github-actions · 2020-11-10T17:09:49Z

Timestamp: 2020-11-20 15:12:37
Buildscan url for ubuntu-workflow run 374598479
https://gradle.com/s/cathvdosoytiw

codecov-io · 2020-11-10T17:37:08Z

Codecov Report

Merging #1310 (cf593ce) into master (501ea71) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1310   +/-   ##
=========================================
  Coverage     78.99%   78.99%           
  Complexity      703      703           
=========================================
  Files           244      244           
  Lines          4685     4685           
  Branches        825      825           
=========================================
  Hits           3701     3701           
  Misses          555      555           
  Partials        429      429

bootstraponline · 2020-11-12T13:10:56Z

Having reference in description (ex. Fixes GitHub action to validate is any user is assigned to pull request #1092)

I think we always want a reference to the ticket in the description for pull requests related to an issue (this is how GitHub links PRs to issues). GitHub doesn't understand the branch convention.

piotradamczyk5 · 2020-11-12T13:29:52Z

Having reference in description (ex. Fixes GitHub action to validate is any user is assigned to pull request #1092)

I think we always want a reference to the ticket in the description for pull requests related to an issue (this Yis how GitHub links PRs to issues). GitHub doesn't understand the branch convention.

Yes, the branch is just a fallback :) 99% of cases it will take it from description

adamfilipow92 · 2020-11-17T12:12:32Z

flank-scripts/src/main/kotlin/flank/scripts/pullrequest/SetLabels.kt

+private suspend fun getLabelsFromIssue(githubToken: String, issueNumber: Int) =
+    Fuel.get("https://api.github.com/repos/Flank/flank/issues/$issueNumber/labels")
+        .appendHeader("Accept", "application/vnd.github.v3+json")
+        .appendHeader("Authorization", "token $githubToken")


In GitHubApi.kt we have function appendHeaders. This function adds these headers to the request. Maybe we could use these functions in this and other places? WDYT?

I think that this is very good idea

adamfilipow92 · 2020-11-17T14:46:04Z

flank-scripts/src/main/kotlin/flank/scripts/pullrequest/SetAssignees.kt

+suspend fun setAssigneesToPullRequest(githubToken: String, pullRequestNumber: Int, assignees: List<String>) {
+    Fuel.post("https://api.github.com/repos/Flank/flank/issues/$pullRequestNumber/assignees")
+        .appendHeader("Accept", "application/vnd.github.v3+json")
+        .appendHeader("Authorization", "token $githubToken")


Here we can use .appendHeaders(githubToken) too

flank-scripts/src/main/kotlin/flank/scripts/pullrequest/GitHubIssuePropertiesCopy.kt

pawelpasterz

I've created test issue #1330 and pr #1331 and ran script according to the test plan. It's amazing how fast it is, I really like this feature. The only difference is I am assigned in PR. Also, it could be useful to copy epics

pawelpasterz · 2020-11-18T13:42:14Z

Any idea why it was repeated 3 times?

piotradamczyk5 · 2020-11-18T13:44:42Z

Any idea why it was repeated 3 times?

Zen hub API set estimates each time you run a script where Github set diff only

piotradamczyk5 · 2020-11-18T15:05:21Z

I've created test issue #1330 and pr #1331 and ran script according to the test plan. It's amazing how fast it is, I really like this feature. The only difference is I am assigned in PR. Also, it could be useful to copy epics

Fixed! Thanks for finding it!

In case of copy epics, it is not so easy using Zenhub API, because it does not return epic for an issue. You could just get all epics and list issues in it, so it will not be very optimal

pawelpasterz · 2020-11-19T05:26:03Z

I've created test issue #1330 and pr #1331 and ran script according to the test plan. It's amazing how fast it is, I really like this feature. The only difference is I am assigned in PR. Also, it could be useful to copy epics

Fixed! Thanks for finding it!

In case of copy epics, it is not so easy using Zenhub API, because it does not return epic for an issue. You could just get all epics and list issues in it, so it will not be very optimal

I see, thanks for info.

adamfilipow92 · 2020-11-20T14:30:39Z

flank-scripts/src/test/kotlin/flank/scripts/GithubMockServerHandler.kt

+    url.endsWith("/releases/latest") && request.containsSuccessHeader() -> request.buildResponse(
+        GitHubRelease("v20.08.0").toJson(),
+        200
+    )


Could we use one style of argument formatting in this file?

adamfilipow92

👍

…IssuePropertiesCopy.kt Co-authored-by: pawelpasterz <[email protected]>

piotradamczyk5 self-assigned this Nov 10, 2020

piotradamczyk5 force-pushed the #1092_copy_properties_to_pull_request branch 2 times, most recently from 7409fbd to fe8d175 Compare November 10, 2020 17:24

piotradamczyk5 added Feature Tiger 🐯 labels Nov 12, 2020

piotradamczyk5 force-pushed the #1092_copy_properties_to_pull_request branch from 0bbe934 to 34d0d0b Compare November 12, 2020 13:28

piotradamczyk5 assigned adamfilipow92 Nov 13, 2020

piotradamczyk5 force-pushed the #1092_copy_properties_to_pull_request branch from 12a0fdb to d40dd29 Compare November 13, 2020 16:42

piotradamczyk5 requested review from jan-goral, adamfilipow92, zuziaka, bootstraponline, pawelpasterz and Sloox November 13, 2020 16:43

piotradamczyk5 marked this pull request as ready for review November 13, 2020 16:43

adamfilipow92 reviewed Nov 17, 2020

View reviewed changes

piotradamczyk5 force-pushed the #1092_copy_properties_to_pull_request branch from 04f5aca to cc30c4e Compare November 17, 2020 14:40

adamfilipow92 reviewed Nov 17, 2020

View reviewed changes

piotradamczyk5 requested a review from adamfilipow92 November 17, 2020 14:54

pawelpasterz reviewed Nov 18, 2020

View reviewed changes

flank-scripts/src/main/kotlin/flank/scripts/pullrequest/GitHubIssuePropertiesCopy.kt Outdated Show resolved Hide resolved

pawelpasterz suggested changes Nov 18, 2020

View reviewed changes

piotradamczyk5 requested a review from pawelpasterz November 18, 2020 13:45

piotradamczyk5 marked this pull request as draft November 18, 2020 14:29

piotradamczyk5 marked this pull request as ready for review November 18, 2020 15:04

pawelpasterz approved these changes Nov 19, 2020

View reviewed changes

adamfilipow92 reviewed Nov 20, 2020

View reviewed changes

adamfilipow92 approved these changes Nov 20, 2020

View reviewed changes

Piotr Adamczyk and others added 15 commits November 20, 2020 16:07

ci: Copy properties from issue to pull request

6090778

Clean up code

91e5ce9

add some tests and refactor mock server

3a59701

added tests

f7b6ffb

added github job

957cb19

added documentation

0431e6d

update documentation and action

db4256e

update tests

ebe8649

change for PR

eb6b211

change for PR

846b747

Update flank-scripts/src/main/kotlin/flank/scripts/pullrequest/GitHub…

30ea91f

…IssuePropertiesCopy.kt Co-authored-by: pawelpasterz <[email protected]>

fix setting assignees

5acd0ea

fixed test

fc2f951

add tests

7ae1bea

Update GithubMockServerHandler.kt

bd87d68

piotradamczyk5 force-pushed the #1092_copy_properties_to_pull_request branch from a3753e9 to bd87d68 Compare November 20, 2020 15:07

piotradamczyk5 merged commit ac5a2a8 into master Nov 20, 2020

piotradamczyk5 deleted the #1092_copy_properties_to_pull_request branch November 20, 2020 15:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Copy properties from issue to pull request #1310

ci: Copy properties from issue to pull request #1310

piotradamczyk5 commented Nov 10, 2020 •

edited

Loading

github-actions bot commented Nov 10, 2020 •

edited

Loading

codecov-io commented Nov 10, 2020 •

edited

Loading

bootstraponline commented Nov 12, 2020

piotradamczyk5 commented Nov 12, 2020

adamfilipow92 Nov 17, 2020

piotradamczyk5 Nov 17, 2020

adamfilipow92 Nov 17, 2020

piotradamczyk5 Nov 17, 2020

pawelpasterz left a comment •

edited

Loading

pawelpasterz commented Nov 18, 2020 •

edited

Loading

piotradamczyk5 commented Nov 18, 2020

piotradamczyk5 commented Nov 18, 2020 •

edited

Loading

pawelpasterz commented Nov 19, 2020

adamfilipow92 Nov 20, 2020

adamfilipow92 left a comment

ci: Copy properties from issue to pull request #1310

ci: Copy properties from issue to pull request #1310

Conversation

piotradamczyk5 commented Nov 10, 2020 • edited Loading

Test Plan

Checklist

github-actions bot commented Nov 10, 2020 • edited Loading

codecov-io commented Nov 10, 2020 • edited Loading

Codecov Report

bootstraponline commented Nov 12, 2020

piotradamczyk5 commented Nov 12, 2020

adamfilipow92 Nov 17, 2020

Choose a reason for hiding this comment

piotradamczyk5 Nov 17, 2020

Choose a reason for hiding this comment

adamfilipow92 Nov 17, 2020

Choose a reason for hiding this comment

piotradamczyk5 Nov 17, 2020

Choose a reason for hiding this comment

pawelpasterz left a comment • edited Loading

Choose a reason for hiding this comment

pawelpasterz commented Nov 18, 2020 • edited Loading

piotradamczyk5 commented Nov 18, 2020

piotradamczyk5 commented Nov 18, 2020 • edited Loading

pawelpasterz commented Nov 19, 2020

adamfilipow92 Nov 20, 2020

Choose a reason for hiding this comment

adamfilipow92 left a comment

Choose a reason for hiding this comment

piotradamczyk5 commented Nov 10, 2020 •

edited

Loading

github-actions bot commented Nov 10, 2020 •

edited

Loading

codecov-io commented Nov 10, 2020 •

edited

Loading

pawelpasterz left a comment •

edited

Loading

pawelpasterz commented Nov 18, 2020 •

edited

Loading

piotradamczyk5 commented Nov 18, 2020 •

edited

Loading