fix: Handling broken token issues #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
bootstraponline,
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
Timestamp: 2020-11-09 08:16:42 |
bootstraponline
changed the title
|
does this fix the windows issues with google tokens? 👍 |
I think that it was fixed before by @adamfilipow92 |
bootstraponline
force-pushed
the
#1293_invalid_token_handling
branch
from
4a7c327 to
b5bb0ce
Compare
piotradamczyk5
force-pushed
the
#1293_invalid_token_handling
branch
2 times, most recently
from
9cee851 to
9c17363
Compare
Sloox
reviewed
Nov 6, 2020
| @Test | ||
| fun `getDefaultBucket on 400 with authentication error should throw exception with specific message`() { | ||
| val expected = """ | ||
| Could not load user authentication, please |
Sloox
approved these changes
Nov 6, 2020
|
@Mergifyio rebase |
added 2 commits
November 9, 2020 08:11
|
Command
|
bootstraponline
force-pushed
the
#1293_invalid_token_handling
branch
from
9c17363 to
8431552
Compare
adamfilipow92
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1293
Test Plan
When there is a problem with the token listed in the checklist, a proper message with fix instructions is displayed and a bad token file is deleted
Checklist