feat: add test targets for shard

[Sloox]

Fixes #1203
add test targets for shard
https://cloud.google.com/sdk/gcloud/reference/alpha/firebase/test/android/run#--test-targets-for-shard

Test Plan

How do we know the code works?

1. Run config flank-single-shards-simple.yml

   gcloud:
     app: app-debug.apk
     test: app-multiple-success-debug-androidTest.apk
     test-targets-for-shard:
       - class com.example.test_app.bar.BarInstrumentedTest
       - class com.example.test_app.foo.FooInstrumentedTest
   

2. Observe a matrix with 2 shards is running
3. Each shard contains only 2 tests, and one of them is ignored
4. Number of dumped shards is equal to expected (2)

Above is just a simple test plan, please, feel free to play around with this feature.

Checklist

• Documented
• Unit tested

[github-actions]

Timestamp: 2020-11-18 16:42:11
Buildscan url for ubuntu-workflow run 370616001
https://gradle.com/s/rt3d6hqxteljc

[codecov-io]

Codecov Report

Merging #1299 (56a9572) into master (415330a) will decrease coverage by 0.42%.
The diff coverage is 62.63%.

@@             Coverage Diff              @@
##             master    #1299      +/-   ##
============================================
- Coverage     79.55%   79.13%   -0.43%     
- Complexity      735      738       +3     
============================================
  Files           237      237              
  Lines          4579     4640      +61     
  Branches        796      808      +12     
============================================
+ Hits           3643     3672      +29     
- Misses          526      550      +24     
- Partials        410      418       +8     

[Sloox]

Unfortunately still a printing issue

I am unsure how to approach this one? Any ideas?

[adamfilipow92]

Unfortunately still a printing issue

I am unsure how to approach this one? Any ideas?

ShardChunks is a List of List of Strings this is the reason why the single string is wrapped in []

so you could do something like this

fun shardsChunksListToString(objects: ShardChunks): String {
        if (objects.isNullOrEmpty()) return ""
        return NEW_LINE + objects.flatten()
            .joinToString("\n") { "         $it" }
    }

This should produce a result like:

      test-targets-for-shard: 
         class com.example.test_app.bar.BarInstrumentedTest
         class com.example.test_app.foo.FooInstrumentedTest

[adamfilipow92]

• Tested with filters
• Tested without filters
• Now output looks correct

    num-flaky-test-attempts: 0
      test-targets-for-shard: 
        - class com.example.test_app.bar.BarInstrumentedTest
        - class com.example.test_app.foo.FooInstrumentedTest

Good work 👍

[jan-goral]

Do we really need 2 methods named calculateDummyShards which both have only one call? IMO It's unnecessary redundancy. Besides that ArgHelper will be refactored soon.

[pawelpasterz]

I believe the intention was to be in line with the current implementation

flank/test_runner/src/main/kotlin/ftl/run/platform/android/CreateAndroidTestContext.kt

Lines 49 to 52 in 733e444

	private fun InstrumentationTestContext.calculateShards(
	args: AndroidArgs,
	testFilter: TestFilter = TestFilters.fromTestTargets(args.testTargets)
	): InstrumentationTestContext = ArgsHelper.calculateShards(

As you mentioned, there will be a huge refactor soon so within this PR we either refactor all similar occurrences or leave it as it is

[Sloox]

removed the reference from ArgsHelper 👍

[Sloox]

@pawelpasterz I removed the reference from ArgsHelper. and merely moved the logic into the CreateAndroidTestContext

[jan-goral]

Would be great to have a dedicated yml config for each testable flank's feature. So, the config from the description could be placed in the repository.

[EDIT] My bad, it already is

[piotradamczyk5]

@Mergifyio refresh

[mergify]

Command refresh: success

Pull request refreshed