Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect printed shards number #1298

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1296

Test Plan

How do we know the code works?

  1. Prepare config:
    gcloud:
      app: [app from test artifacts]
      test: [multiple-success test apk]
    flank:
      max-test-shards: 50
    
  2. Run flank for android with --dump-shards
  3. Observe Saved 15 shards to android_shards.json is being printed.

Checklist

  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Timestamp: 2020-11-04 16:41:13
Buildscan url for ubuntu-workflow run 345918546
https://gradle.com/s/ls64leweif7s2

@bootstraponline bootstraponline force-pushed the 1296-fix-incorrect-printed-shards-number branch from 4de49c4 to 226fd01 Compare November 4, 2020 16:36
@codecov-io
Copy link

Codecov Report

Merging #1298 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1298   +/-   ##
=========================================
  Coverage     79.71%   79.71%           
  Complexity      728      728           
=========================================
  Files           235      235           
  Lines          4525     4525           
  Branches        780      780           
=========================================
  Hits           3607     3607           
  Misses          516      516           
  Partials        402      402           

@mergify mergify bot merged commit 7b6b0ca into master Nov 5, 2020
@mergify mergify bot deleted the 1296-fix-incorrect-printed-shards-number branch November 5, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect number when dumping shards [android]
4 participants