fix: Print formatted message instead of throwing NPE #1295

pawelpasterz · 2020-11-04T07:02:06Z

Test Plan

How do we know the code works?

Prepare config, for instance:
```
gcloud:
  app: [any app]
flank:
  legacy-junit-result:
```
(notice no value for legacy-junit-result)
Run flank with created config
Flank run should terminate with a message Invalid value for [legacy-junit-result]: no argument value found and without any stack trace
Run again but with --legacy-junit-result flag
Flank should proceed normally and legacy-junit-result should be equal true

github-actions · 2020-11-04T07:08:33Z

Timestamp: 2020-11-04 07:08:33
Buildscan url for ubuntu-workflow run 345020073
https://gradle.com/s/3b3xkc6mpg7tq

Sloox

Nice change!

pawelpasterz requested review from Sloox, zuziaka, jan-goral, adamfilipow92 and piotradamczyk5 November 4, 2020 07:02

pawelpasterz self-assigned this Nov 4, 2020

bootstraponline force-pushed the 1294-fix-NPE-with-incorrect-config branch from 8bbda51 to a71e767 Compare November 4, 2020 07:02

Print formatted message instead of throwing NPE

ca0077f

pawelpasterz force-pushed the 1294-fix-NPE-with-incorrect-config branch from a71e767 to ca0077f Compare November 4, 2020 07:03

Sloox approved these changes Nov 4, 2020

View reviewed changes

piotradamczyk5 approved these changes Nov 4, 2020

View reviewed changes

mergify bot merged commit 5547625 into master Nov 4, 2020

mergify bot deleted the 1294-fix-NPE-with-incorrect-config branch November 4, 2020 16:35