feat: Add --test-special-entitlements for iOS #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
Sloox,
adamfilipow92,
pawelpasterz,
zuziaka,
bootstraponline and
jan-goral
|
Timestamp: 2020-11-02 14:40:18 |
piotradamczyk5
added
iOS
New Option
bootstraponline
force-pushed
the
#1197_add--test-special-entitlements
branch
from
394ccde to
98c2904
Compare
pawelpasterz
approved these changes
Nov 2, 2020
bootstraponline
force-pushed
the
#1197_add--test-special-entitlements
branch
from
98c2904 to
1360d0b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1291 +/- ##
============================================
- Coverage 79.66% 79.66% -0.01%
- Complexity 724 725 +1
============================================
Files 235 235
Lines 4505 4514 +9
Branches 777 778 +1
============================================
+ Hits 3589 3596 +7
- Misses 515 516 +1
- Partials 401 402 +1 |
Sloox
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1197
Test Plan
--test-special-entitlementsis properly passed as a parameter using CLI andyamlconfig.I've tested this option using Gcloud and Flank and behavior is the same.
I do not know how to test the impact of this option on tests
Checklist