Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix getting PR number on pull_request_review #1275

Merged
merged 5 commits into from
Oct 28, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Oct 27, 2020

Test Plan

How do we know the code works?

PR number for event pull_request_review is not correctly delivered withing ${{github.event.number}}.
It needs to be fetched from $GITHUB_REF

@piotradamczyk5 piotradamczyk5 marked this pull request as draft October 27, 2020 15:10
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review October 27, 2020 15:15
@piotradamczyk5 piotradamczyk5 marked this pull request as draft October 27, 2020 15:16
@codecov-io
Copy link

Codecov Report

Merging #1275 into master will increase coverage by 0.01%.
The diff coverage is 82.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1275      +/-   ##
============================================
+ Coverage     79.65%   79.67%   +0.01%     
- Complexity      715      723       +8     
============================================
  Files           233      233              
  Lines          4399     4437      +38     
  Branches        756      759       +3     
============================================
+ Hits           3504     3535      +31     
- Misses          496      503       +7     
  Partials        399      399              

@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review October 27, 2020 15:19
@pawelpasterz
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Oct 28, 2020

Command rebase: action_required

Pull request must be rebased manually.
GitHub App like Mergify are not allowed to rebase pull request where .github/workflows is changed.

@piotradamczyk5 piotradamczyk5 merged commit 372bdc2 into master Oct 28, 2020
@piotradamczyk5 piotradamczyk5 deleted the fix_getting_pr_number branch October 28, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants