Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Additional Ipas option to iOS #1273

Merged
merged 1 commit into from
Oct 27, 2020
Merged

feat: Add Additional Ipas option to iOS #1273

merged 1 commit into from
Oct 27, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Oct 26, 2020 •
edited
Loading

Fixes #1195

Test Plan

How do we know the code works?

  1. Add additional ipa using --additional-ipas or using .yaml option additional-ipas.
  2. Check if .ipa files are uploaded

Checklist

  • Documented
  • Unit tested

@piotradamczyk5 piotradamczyk5 added iOS Tiger 🐯 New Option Used to track PR with new configuration option (useful when updating fladle) labels Oct 26, 2020
@piotradamczyk5 piotradamczyk5 self-assigned this Oct 26, 2020
@codecov-io
Copy link

Codecov Report

Merging #1273 into master will increase coverage by 0.01%.
The diff coverage is 82.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1273      +/-   ##
============================================
+ Coverage     79.65%   79.67%   +0.01%     
- Complexity      715      723       +8     
============================================
  Files           233      233              
  Lines          4399     4437      +38     
  Branches        756      759       +3     
============================================
+ Hits           3504     3535      +31     
- Misses          496      503       +7     
  Partials        399      399

Sloox
Sloox approved these changes Oct 27, 2020
View reviewed changes
test_runner/src/main/kotlin/ftl/args/CreateIosArgs.kt
@@ -24,6 +24,7 @@ private fun createIosArgs(
xctestrunZip = gcloud.test?.normalizeFilePath().orEmpty(),
xctestrunFile = gcloud.xctestrunFile?.normalizeFilePath().orEmpty(),
xcodeVersion = gcloud.xcodeVersion,
additionalIpas = gcloud.additionalIpas!!.map { it.normalizeFilePath() },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!! always make me nervous

@mergify mergify bot merged commit 3b7b8e9 into master Oct 27, 2020
@mergify mergify bot deleted the #1195_add_additional_ipas_option branch October 27, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

Assignees

@piotradamczyk5 piotradamczyk5

Labels
iOS New Option Used to track PR with new configuration option (useful when updating fladle) Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS | Add --additional-ipas
4 participants
@piotradamczyk5 @codecov-io @Sloox @pawelpasterz