Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix integration test counter and trigger #1272

Merged
merged 11 commits into from
Oct 27, 2020
Merged

fix: Fix integration test counter and trigger #1272

merged 11 commits into from
Oct 27, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Oct 26, 2020 •
edited
Loading

Fixes #1271

Test Plan

How do we know the code works?

Integration tests run only if have 2 or more approves

Checklist

  • Fix integrations test counter
  • Make it as separate job
  • Move all integration tests( except WSL) to same file

@piotradamczyk5 piotradamczyk5 changed the title Update integration_tests.yml fix: Fix integration test counter and trigger Oct 26, 2020
@piotradamczyk5 piotradamczyk5 self-assigned this Oct 26, 2020
@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review October 26, 2020 13:46
@piotradamczyk5 piotradamczyk5 marked this pull request as draft October 27, 2020 08:36
@piotradamczyk5
Copy link
Contributor Author

It works properly on the fork, however. Here it seems that it does not count approves.
I must investigate it more

@piotradamczyk5 piotradamczyk5 marked this pull request as ready for review October 27, 2020 09:08
@piotradamczyk5
Copy link
Contributor Author

It works properly on the fork, however. Here it seems that it does not count approves.
I must investigate it more

fixed using custom api call

@piotradamczyk5 piotradamczyk5 merged commit ecd6c9c into master Oct 27, 2020
@piotradamczyk5 piotradamczyk5 deleted the #1271_fix_integration_test_counter branch October 27, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziaka zuziaka Awaiting requested review from zuziaka

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@piotradamczyk5 piotradamczyk5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integration test counter
3 participants
@piotradamczyk5 @Sloox @pawelpasterz