Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Other Files for iOS #1267

Merged
merged 1 commit into from
Oct 26, 2020
Merged

feat: Add Other Files for iOS #1267

merged 1 commit into from
Oct 26, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Oct 23, 2020 •
edited
Loading

Fixes #1199

Test Plan

How do we know the code works?

Other files could be sent using --other-files CLI or other-files YAML config for iOS

Checklist

  • Documented
  • Unit tested

@codecov-io
Copy link

Codecov Report

Merging #1267 into master will decrease coverage by 0.07%.
The diff coverage is 61.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1267      +/-   ##
============================================
- Coverage     79.66%   79.58%   -0.08%     
- Complexity      715      716       +1     
============================================
  Files           233      233              
  Lines          4401     4414      +13     
  Branches        757      758       +1     
============================================
+ Hits           3506     3513       +7     
- Misses          496      502       +6     
  Partials        399      399

@piotradamczyk5 piotradamczyk5 force-pushed the #1199_ios_add_other_files branch from 3f7d172 to 35eac80 Compare October 23, 2020 14:29
@piotradamczyk5 piotradamczyk5 added iOS New Option Used to track PR with new configuration option (useful when updating fladle) labels Oct 23, 2020
@bootstraponline bootstraponline force-pushed the #1199_ios_add_other_files branch from 35eac80 to 8ecc19d Compare October 26, 2020 05:07
pawelpasterz
pawelpasterz reviewed Oct 26, 2020
View reviewed changes
docs/index.md
@@ -146,6 +146,15 @@ gcloud:
# locale: es_ES
# orientation: landscape


## A list of device-path=file-path pairs that specify the paths of the test device and the files you want pushed to the device prior to testing.
Copy link
Contributor

@pawelpasterz pawelpasterz Oct 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## A list of device-path=file-path pairs that specify the paths of the test device and the files you want pushed to the device prior to testing.
## A list of device-path=file-path pairs that specify the paths of the test device and the files you want to be pushed to the device prior to testing.

But I can see it's copy-pasted from https://cloud.google.com/sdk/gcloud/reference/alpha/firebase/test/ios/run#--other-files so I might be wrong and it's written correctly?
@Sloox ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy paste from google page

Copy link
Contributor

@Sloox Sloox Oct 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think leave it if its copy pasted. But yes you are correct. @pawelpasterz good spot ;) i hope to one day be like this with Polish 👍

@pawelpasterz
Copy link
Contributor

It would be nice to have the possibility of testing it on the actual app. If it's doable, please update the test plan

@bootstraponline bootstraponline force-pushed the #1199_ios_add_other_files branch from 8ecc19d to c4f05df Compare October 26, 2020 07:31
@piotradamczyk5
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Oct 26, 2020

Command rebase: success

Branch already up to date

@Sloox
Copy link
Contributor

Sloox commented Oct 26, 2020

It would be nice to have the possibility of testing it on the actual app. If it's doable, please update the test plan

integration tests? :)

@pawelpasterz
Copy link
Contributor

It would be nice to have the possibility of testing it on the actual app. If it's doable, please update the test plan

integration tests? :)

I'll try to cover it within #1212

@piotradamczyk5
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link

mergify bot commented Oct 26, 2020

Command refresh: success

Pull request refreshed

@mergify mergify bot merged commit 4113afc into master Oct 26, 2020
@mergify mergify bot deleted the #1199_ios_add_other_files branch October 26, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sloox Sloox Sloox approved these changes

@pawelpasterz pawelpasterz pawelpasterz left review comments

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@adamfilipow92 adamfilipow92

@piotradamczyk5 piotradamczyk5

Labels
iOS New Option Used to track PR with new configuration option (useful when updating fladle) Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS | Add --other-files
5 participants
@piotradamczyk5 @codecov-io @pawelpasterz @Sloox @adamfilipow92