fix: Add additional index to matrix when multiple test runs #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1261 +/- ##
=========================================
Coverage 79.65% 79.66%
Complexity 715 715
=========================================
Files 233 233
Lines 4399 4401 +2
Branches 756 757 +1
=========================================
+ Hits 3504 3506 +2
Misses 496 496
Partials 399 399 |
adamfilipow92
requested review from
jan-goral,
zuziaka,
bootstraponline,
pawelpasterz,
piotradamczyk5 and
Sloox
|
After a call with @pawelpasterz, we want to add some tests, so I convert it to draft |
Sloox
approved these changes
Oct 22, 2020
bootstraponline
force-pushed
the
1258-fix-indexing-matrices-on-multiple-tests-run
branch
from
2333568 to
8817552
Compare
piotradamczyk5
approved these changes
Oct 22, 2020
mergify
bot
deleted the
1258-fix-indexing-matrices-on-multiple-tests-run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1258
Test Plan
num-test-runsset Flank should add to the matrix directory name_$indexon end.num-test-runsnot set directory name shouldn't contain an additional index.