test: Added missing test t cover duplicated tests issue #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotradamczyk5
requested review from
bootstraponline,
Sloox,
zuziaka,
pawelpasterz,
jan-goral and
adamfilipow92
|
Title does not follow the guidelines of Conventional Commits.
|
piotradamczyk5
changed the title
Sloox
approved these changes
Aug 26, 2020
bootstraponline
approved these changes
Aug 26, 2020
pgreze
added a commit
to mercari/flank
that referenced
this pull request
Oct 21, 2020
* style: Update detekt (Flank#1000) * Inital update of detekt * Detekt upgrade and yml modifications * Finialize detekt and some minor code changes * update release notes * feat: Implement command `models describe` for ios/android (Flank#995) * feat: auto generate release notes for next release (Flank#996) * Added generation of release notes * added tests * updated documentation * Delete next release notes * fix: failing tests (Flank#1007) * fix: failing tests * Update DumpShardsKtTest.kt * feat: Implement ip-blocks list command (Flank#999) * fix: generation of release notes (Flank#1005) * feat: Add ip-blocks command to test-environment command (Flank#1012) * ci: Generate release notes for Github release description (Flank#1011) * Generate release notes for GitHub release description * updated documentation * Create .mergify.yml * Generating docs before release (Flank#1013) * ci: Update mergify configuration (Flank#1015) * Flank#1008 Update mergify configuration to make rebase before merge * Post a message when Pr bad PR title * fix: rate limit exceeded (Flank#919) * Add pseudocode for flank v20.06.2 poll matrices * Add pseudocode for flank v20.06.2 matrix finish * Update table & add conclusions. * Calculate TestOutcome from environments or steps [DRAFT] TODO: * Calculate billable minutes * Fix tests * Update implementation * Fix detect issues * Fix SavedMatrixTest * Fix UtilsTest * Fix MockServer * Fix MatrixMapTest & SavedMatrixTest * Update summary_output.md * Update summary_output.md * Update release_notes.md * Adjust implementation for summary result of all devices * Remove old implementation & clean * Fix NPE * Update test_runner/src/main/kotlin/ftl/reports/outcome/TestOutcomeContext.kt Co-authored-by: piotradamczyk5 <[email protected]> * CR fixes * Fix typo * Fix double negation * Remove unused `notErrors` TODO * map BadMatrixError error to proper error code * Update release_notes.md * Make BadMatrixError be properly handled as error code 15 * Fix indention * Fix DumpShardsKtTest is not calling MockServer * Fix CreateJUnitTestSuiteKtTest * Fix nullability Co-authored-by: piotradamczyk5 <[email protected]> * Fetch artifacts async (Flank#1018) * Make release notes more organized (Flank#1020) * chore: release notes for v20.08.2 Co-authored-by: piotradamczyk5 <[email protected]> * ci: Publish to GitHub packages (Flank#1022) * Flank#955 Publish to GitHub packages * updated README.md * fix: Release notes message at GitHub release (Flank#1023) * fix: Release notes message at GitHub release * fixed detekt * Update kotlin to v1.4 (Flank#1025) * Fix otherNativeCrash NPE (Flank#1027) * ci: Disable publishing snapshot to Github Packages (Flank#1031) * [Automatic PR] Generate release notes (Flank#1032) Co-authored-by: jan-gogo <[email protected]> * refactor: Savedmatrix immutability change (Flank#1028) * Saved matrix refactor 1.0 * Saved matrix bug fixes 1.0 * Recursion error fix * Fixed failing tests * Fixed github flows failing tests * Further fixes besed on pullrequest comments, Outcomedetails nullability change * Further fixes besed on pullrequest comments * More code review comments * Remove vars from updatedSavedMatrix (Flank#1037) Co-authored-by: Jan Góral <[email protected]> * fix: Size annotations support (Flank#994) * Add androidx size annotations support * Update size samples to match all annotation generations * style: Improve kotlin code formatting (Flank#1039) * More klint options included and autoformat on gradle check * AutoFormatted files based on detekt & klint * Fixes for builds and removal of indentation 8 to 4 * fix: master not compiling (Flank#1044) * Detekt fix 1.0 * Detekt fixed for annotations on single line * feat: A (Flank#1042) feat: Added options for default time and average time * docs: Avoid multiple identical lines printing (Flank#1009) * Update ExecutionStatusPrinter.kt * Update ExecutionStatusPrinter.kt * Update tests * Update MultiLinePrinterTest.kt * Update test_runner/src/main/kotlin/ftl/run/status/ExecutionStatusPrinter.kt Co-authored-by: piotradamczyk5 <[email protected]> * Update ExecutionStatusPrinter.kt * Fix, removing lines on terminals different than intelliJ console * revert changes about printing * Revert changes of MultipleLinePrinterTest * Create 993_multiple_identical_lines_printing.md * Update 993_multiple_identical_lines_printing.md * Update DumpShardsKtTest.kt Co-authored-by: piotradamczyk5 <[email protected]> * feat: Add printing messages for MatrixCanceledError and InfrastructureError (Flank#1043) * Add missing messages * Change wording * feat: Add test axis value column to summary table (Flank#1040) * feat(output): add test axis value column to summary table docs(output): update summary table * Display full device name in outcome table * Update summary_output.md * Fix namings * fix: PR check from fork (Flank#1051) * Fix duplicate tests found (Flank#1048) * refactor: MatrixMap immutability (Flank#1047) * MatrixMap immutability * toSavedMatrixMap immutability * fixed pr request * change the order for the mutabulity of the map * fix: Avoid releasing on document changes only (Flank#1053) * add filter * add filter for test_api * fix: Invoking flank yml on gcloud cli (Flank#1041) * Fast fail when cannot create bucket * added tests and fix device version * update tests * Fix NPE when no devices or Version node * Update Debug.kt * fix imports * Review fixes * Set extension funcs to extension properties * Update Doctor.kt * Update test_runner/src/main/kotlin/ftl/args/yml/YamlDeviceFix.kt Co-authored-by: Jan Góral <[email protected]> Co-authored-by: Jan Góral <[email protected]> * tests: Added missing test t cover duplicated tests issue (Flank#1055) * feat: Added validation of smart-flank-gcs-path to not override different junit results (Flank#1056) * Added validation of smart-flank-gcs-paht to not override full junit by junit and back * Add docs, turn off validation when smart-flank-disable-upload enabled * [Automatic PR] Generate release notes (Flank#1061) Co-authored-by: piotradamczyk5 <[email protected]> * ci: Post slack message about releases (Flank#1058) * Add a release notifier for flankbot TEST * Fix naming & double https issue * Scoped the releasebot to release only * fix: Bad validation of `local-result-dir` by Doctor (Flank#1066) * Change error to an warning, added more detailed information about an error on upload artifacts (Flank#1070) * Added options to minimize the shadowJar process (Flank#1071) * [Automatic PR] Generate release notes (Flank#1074) Co-authored-by: adamfilipow92 <[email protected]> * fix: firebase refresh fails when test zip file doesn't exist (Flank#1052) (Flank#1054) * fix: firebase refresh fails when test zip file doesn't exist (Flank#1052) * renamed `String.proccessFilePath` method to `String.normalizeFilePath` * catching errors from `ArgsHelper.evaluateFilePath` * removed validation from `IosArgsCompanion.load` - only for iOS for now. We need different validations for different commands. TODO: * remove validation from `AndroidArgsCompanion.load` * update tests * Unit tests for ValidateIosArgs - updated unit tests for ValidateIosArgs - code cleaning * Added new validations methods to `ValidateAndoirdArgs` * Add some fixes to ValidateAndroidArgs.kt * AndroidArgs validation flow update * removed validation from `AndroidArgs.load` method * added manual `AndroidArgs.validate()` method call * update unit tests * added new unit tests for AndroidArgs's otherFiles validation * Removed unnecessary AndroidArgs validations * Fix unit tests * Fix unit tests (detect issue) Co-authored-by: Janek Góral <[email protected]> * Revert "Added options to minimize the shadowJar process (Flank#1071)" (Flank#1077) This reverts commit 6907113. * Fix for $ in github workflows (Flank#1079) * Revert "[Automatic PR] Generate release notes (Flank#1074)" (Flank#1082) This reverts commit ef8d5ba. * fix: Flaky Flank-scripts test (Flank#1080) * [Automatic PR] Generate release notes (Flank#1083) Co-authored-by: adamfilipow92 <[email protected]> * Update release.yml (Flank#1087) * Revert "[Automatic PR] Generate release notes (Flank#1083)" (Flank#1088) This reverts commit dbb29ac. * [Automatic PR] Generate release notes (Flank#1089) Co-authored-by: adamfilipow92 <[email protected]> * Update release_notes.md (Flank#1091) * fix: Flank release bot formatting (Flank#1093) * Fix formatting * fix yaml error * fix: Fix gcs files validation (Flank#1100) * Skip validation for gcs files * Add comment * Update tests * [Automatic PR] Generate release notes (Flank#1101) Co-authored-by: piotradamczyk5 <[email protected]> * fix: Matrix path not found in json (Flank#1067) * fix: Matrix path not found in json * Remove fast fail on existing bucket * Update ValidateCommonArgs.kt * Delete ValidateResultsDirUniqueTests.kt * Update ReportManagerTest.kt * Update ReportManagerTest.kt * Remove unused method * detekt * Update test_runner/src/main/kotlin/ftl/reports/util/ReportManager.kt Co-authored-by: Jan Góral <[email protected]> * Print warning when results dir already exist * fix: Matrix path not found in json * Remove fast fail on existing bucket * Update ValidateCommonArgs.kt * Delete ValidateResultsDirUniqueTests.kt * Update ReportManagerTest.kt * Update ReportManagerTest.kt * Remove unused method * detekt * Update test_runner/src/main/kotlin/ftl/reports/util/ReportManager.kt Co-authored-by: Jan Góral <[email protected]> * Print warning when results dir already exist * Fix matching text for legacy Android and iOS Co-authored-by: Adam <[email protected]> Co-authored-by: adamfilipow92 <[email protected]> Co-authored-by: Jan Góral <[email protected]> * feat: print the matrices web link at the end of a run (Flank#1097) * added printing option for matrices web link on end of output * detekt * matrices.validate() moved outside report generation * detekt * Update ReportManagerTest.kt * fix: Shards and Tests count do not match (Flank#1059) * build: update info to build with Java 11 (Flank#1102) * build: update info to build with Java greater than 8 * build: update info to build with Java 11 * build: update info to build with Java 11 * update info about Java 11 * fix: Running iOS test on Linux (Flank#1107) * feat: send slack message for releases (Flank#1104) * First iteration of Github action for slack integration * Added new line * Added new line 2 * Fix PR comments 1. * feat: Support for robo tests without robo script (Flank#1108) * Refactor + implement change * Update tests * Update implementation * Update tests * Add null check * feat: Finialize the slack sending integration with actions (Flank#1110) * Added new way to send slack message to Flank + cookie auth * Add missing empty line Co-authored-by: Jan Góral <[email protected]> * feat: check if gcs path exist before run (Flank#1111) * [Automatic PR] Generate release notes (Flank#1115) Co-authored-by: piotradamczyk5 <[email protected]> * Fixes linux restriction for docker on slack send (Flank#1116) * build(deps): bump http-proxy from 1.18.0 to 1.18.1 in /junit_html_report (Flank#1117) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.18.0...1.18.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: Integration tests for Flank (Flank#1109) * Removed the test command from docker file (Flank#1121) * ci: add new bash scripts for test artifacts generation (Flank#1095) * ci: add new bash scripts for test artifacts generation ci: make flankScripts auto generate jar if needed * fix setup_ios_env script * fix formatting * Update earl_grey_example function * Update gohello copy * Code signing changes in iOS test project * Fix path resolving * Fix base_test_apks on zsh * Added correct path to generate .xctest files * Update test_artifacts.md * Update test_artifacts.md * CR fixes Co-authored-by: Axel Zuziak <[email protected]> * refactor: Use single settings.gradle for flank projects (Flank#1113) * Add basic setup for single setting.gradle.kts * Fix gradlew usage * Fix buildSrc dependencies * Workaround strange mockk error in NextReleaseTagGeneratorTest * update PR comments * update PR comments * update PR comments * Remove check step * update Wrapper version to 6.5.1 * update macOS workflow * Disable integration tests run on build project, fix path to flank.jar Co-authored-by: Piotr Adamczyk <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> Co-authored-by: Adam <[email protected]> * Readded shadowjar minimization (Flank#1125) * fix: Reflect gclouds outcome for robo tests (Flank#1124) * Implement fix for robo outcome * Address PR review comments * Update flank_update script (Flank#1127) * feat: add proguard initial step into Flank configuration (Flank#1078) * Added proguard with default setup * Added proguard config options for succesful build * Update test_runner/proguard/config.pro Co-authored-by: Jan Góral <[email protected]> * added minimization Co-authored-by: Jan Góral <[email protected]> * Disable IT for iOS (Flank#1129) * fix: Bump action versioning * build: Enhance gradle structure (Flank#1128) * Add sub projects and handle gradle warnings * split dependencies, for plugins and versions * Fix dependencies Co-authored-by: Piotr Adamczyk <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> * feat: Allow Flank using different environment variables between test-apks (Flank#1126) * Add support for additional apk env variables * override top level envs by variables from current apk * Update GcAndroidTestMatrixTest.kt * Update AndroidTestConfig.kt * Update AndroidTestConfig.kt * Update AndroidTestConfig.kt * Create using_different_environment_variables_in_different_matrices.md * Add @JsonProperty("environment-variables") to AppTestPair * Update test_runner/src/main/kotlin/ftl/run/platform/android/AndroidTestConfig.kt Co-authored-by: Janek Góral <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> * ci: Add Windows workflow (Flank#1114) * Added windows workflow that is based of ubuntu * Lines * removed the double check * name change * Update argshelper for better pathing on windows * Tests working on Native Windows machine * UTF-8 support * Cancel a previously running command * Bash test removal due to wsl incompability * fix yaml styling * More workflow windows fixes * Update .github/workflows/windows_workflow.yml Co-authored-by: piotradamczyk5 <[email protected]> * Fixes and additions * Update test_runner/gradle.properties Co-authored-by: Jan Góral <[email protected]> * Pull request fix * Fix ipblocklist windows tests * Fixed PR comments * Fix workflow for integration tests * More fixes for workflows * Further fixes for testing * Removal of Integration tests Co-authored-by: Michael Wright <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> Co-authored-by: Jan Góral <[email protected]> * Fix: Running Code coverage job (Flank#1137) * docs: Update documentation related with test-targets-always-run feature (Flank#1136) * Update documentation related with test-targets-always-run feature * Change command description * Fix typo * docs: Optimization docs addition (Flank#1139) * Docs add v1. * Changed gradlew command * fix: Fix cost report (Flank#1138) * feat: add Java 15 compile support (Flank#1141) * feat: Added java 15 support * update dependencies and BugsnagInitHelper * update README and macos_workflow * fix: Flank-scripts next release tag generation (Flank#1149) * fix: update flank-scripts serialization (Flank#1151) * chore: release notes for v20.09.3 Co-authored-by: piotradamczyk5 <[email protected]> * feat: Auto update dependencies (Flank#1133) * ci: added WSL workflow (Flank#1152) * ci: added WSL workflow * added GCLOUD key variable * set GCLOUD variable as shared * set GCLOUD variable as shared * set GCLOUD variable as shared * WSL ls test for gcloud key * WSL ls test for gcloud key rearrange * Gcloud key debug test * Gcloud key debug test fix * ignore garbage test * added documentation Co-authored-by: Michael Wright <[email protected]> * Fix test artifacts url (Flank#1158) * docs: Investigate flank options (Flank#1131) * Fix dependabot security issues (Flank#1164) * chore: remove duplicated docs (Flank#1162) * fix: release notes slack tweaks (Flank#1161) * Tweaks for sending via slack correctly * remove unused code * build: Dependencies updates (Flank#1166) * [Automatic PR] Dependencies update * Update unit test * Make detekt happy * Revert "Make detekt happy" This reverts commit e5d7f5d. * Revert Gradle update by tool * update detekt to 1.14.0 Co-authored-by: pawelpasterz <[email protected]> Co-authored-by: Pawel Pasterz <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> * Flank action version bump (Flank#1167) * feat: Improve error message on matrix failures (Flank#1159) * Add printing outcome message * Handle MatrixValidationError, some code refractor, fix OutcomeMessageEnum * detekt fixes * Update SavedMatrixTest.kt * Update SavedMatrixTest.kt * Move SavedMatrix.errorMessage to matrix map * Add test for MatrixMap.validate() * Update SavedMatrixTest.kt * feat: Integration tests run when pr is approved and not draft (Flank#1163) * build: Follow up after dependencies update (Flank#1169) * Enable autocorrect feature for detekt * build: update dependencyUpdate configuration Co-authored-by: Piotr Adamczyk <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> * docs: Add FAQ section about sync problems (Flank#1173) * docs: Add FAQ section about sync problems * Update README.md Co-authored-by: Michael Wright <[email protected]> * Update README.md Co-authored-by: Michael Wright <[email protected]> Co-authored-by: bootstraponline <[email protected]> * style: commit files corrected by Detekt (Flank#1165) * Fix flank-scripts test (Flank#1177) * feat: Dump shards and upload on every run (Flank#1171) * Add dump shards with upload * Add dump shards before matrix validation * Move dumpShards before tests run * cr changes * Update test_runner/src/main/kotlin/ftl/cli/firebase/test/ios/IosRunCommand.kt Co-authored-by: piotradamczyk5 <[email protected]> * Add tests to check is dump shards executed on newTestRun * rename tests * Removed redundant mock * added more tests Co-authored-by: piotradamczyk5 <[email protected]> * test: Added cucumber sample app for testing Flank#1118 (Flank#1174) * test: Added cucumber sample app for testing * test: Added cucumber sample app for testing * remove unused files * Update 914_falsy_positive_outcome_for_flaky_tests.md (Flank#1181) * test: Remove verification test for edge cases of incorrect outcome in flaky tests (Flank#1187) * Update SavedMatrixTest.kt * Update SavedMatrixTest.kt * fix: Revert "feat: Dump shards and upload on every run (Flank#1171)" (Flank#1188) * Revert "feat: Dump shards and upload on every run (Flank#1171)" This reverts commit 256147f. * Leave wording * chore: update feature request template * build: Update testing_v1.json (Flank#1193) * Update API json * Regenerate test_api from gcloud 312 testing_v1.json * chore: Update readme * build: Dependencies updates (Flank#1209) * [Automatic PR] Dependencies update * Fixups Co-authored-by: pawelpasterz <[email protected]> Co-authored-by: Pawel Pasterz <[email protected]> * docs: Added documentation about Cucumber support (Flank#1190) * ci: Enable RC versions for gradle (dependency update task) (Flank#1210) * RC enabled for gradle * Update docs * feat: Android integration tests run on non wsl windows (Flank#1175) * Allow tests to get output from flank on windows * Added non wsl windows workflow file * Update windows-non-wsl-workflow.yml * Minor fixes for windows build * Neaten CommandHHelper and add misisng bat file * Name change * PR comments 1 * PR comments 2 * Return type removal * Return type removal #2 Co-authored-by: Michael Wright <[email protected]> * feat: Added printing missing options (Flank#1214) * feat: Added printing missing options * feat: Added printing missing options * Remove carriage line Co-authored-by: Michael Wright <[email protected]> * docs: Added documentation about missing options (Flank#1215) * feat: Grant permissions addition (Flank#1186) * Added grant permissions * Added tests * fixed spaces * Added grant permissions * Added tests * fixed spaces * Added documentation * single line * Proper single line * Added defaults and autograntpermissions * Fix pr comments 2 * negate autogrant * Fix tests * Name change * Fixed tests 2 * ci: Add scripts for test artifacts managment (Flank#1148) * Add work in progress implementation * Update work in progress implementation * Update work in progress implementation * Increase flank scripts min heap size for preventing OOM when uploading artifacts zip * Move DependencyUpdatesTask to gradle root to cover all dependencies * Expose test artifacts functions as cli commands * Update test_artifacts.md * Add resolveArtifacts gradle task * Remove legacy TestArtifact * remove unused file * Fix resolveArtifacts task * code improvements and fixes * Fix tests * CR fixes * Replace okhttp download with fuel * Fix symbolic link unit test * Add env variables to integration tests workflow * Add env variables to wsl workflow * Add missing env variables Co-authored-by: Piotr Adamczyk <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> * Add missing env variables (Flank#1225) * build: Dependencies updates (Flank#1228) * [Automatic PR] Dependencies update * Change kotlin_serialization version Co-authored-by: pawelpasterz <[email protected]> Co-authored-by: Pawel Pasterz <[email protected]> * Update dpocumentation (Flank#1229) * Fix resolveArtifacts (Flank#1232) * Fix empty branch name for some workflows (Flank#1236) * fix: Always dump shards (Flank#1221) * Add dump shards on run ios/android tests * Added tests and upload on gcs * Add ios tests * Add android test to verify calculation shards is called one * Add obfuscate option to args and use in testRun * Update DumpShardsKtTest.kt * Update CreateIosArgs.kt * remove unnecessary json * Update DumpShardsKtTest.kt * Update GetAndroidMatrixShards.kt * Cr fixes * Fix creating empty dump on robo tests * Update test_runner/src/main/kotlin/ftl/cli/firebase/test/android/AndroidRunCommand.kt Co-authored-by: Jan Góral <[email protected]> Co-authored-by: Jan Góral <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> * fix: Fix withClassName filter (Flank#1233) * feat: Add type (Flank#1230) * Add type * Finialize the type parameter * Better unit tests * Added more assertiveness for the Type * detekt fixes * Added tests and fixed erronous ones * Nicer name outputs * Add current date to dependecy PR (Flank#1240) Co-authored-by: piotradamczyk5 <[email protected]> * docs: Add flank website code (Flank#1222) * Add flank website code * Fix subsections & exit codes table * Update subsections on index.md Co-authored-by: piotradamczyk5 <[email protected]> * Disable cache for shadowJar task (Flank#1243) * fix: Flank web documentation link (Flank#1247) * [Automatic PR] Dependencies update (Flank#1252) Co-authored-by: pawelpasterz <[email protected]> * feat: Scenario Labels (Flank#1238) * Added scenario-labels v1 * Added tests for scenario labels * Updated documentation * ci: Update deprecated options ::set-env and ::add-path (Flank#1248) * fix: Fix running flank workflows on Windows (Flank#1250) * fix: Fix running flankScripts on Windows * skip ios test runs on Windows * fix WSL workflow by setting environment variables * feat: Added scenario-numbers (Flank#1244) * Added scenario-numbers * Fix merge bugs and tests * Added tests * Fixed invalid test * ci: Use Github app token for creating release notes (Flank#1253) Co-authored-by: Michael Wright <[email protected]> Co-authored-by: adamfilipow92 <[email protected]> Co-authored-by: piotradamczyk5 <[email protected]> Co-authored-by: pawelpasterz <[email protected]> Co-authored-by: bootstraponline <[email protected]> Co-authored-by: Jan Góral <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: piotradamczyk5 <[email protected]> Co-authored-by: jan-gogo <[email protected]> Co-authored-by: Matthew Page <[email protected]> Co-authored-by: adamfilipow92 <[email protected]> Co-authored-by: Axel Zuziak <[email protected]> Co-authored-by: Janek Góral <[email protected]> Co-authored-by: Adam <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Axel Zuziak <[email protected]> Co-authored-by: Piotr Adamczyk <[email protected]> Co-authored-by: Michael Wright <[email protected]> Co-authored-by: pawelpasterz <[email protected]> Co-authored-by: Pawel Pasterz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1049
Test Plan
Task #1048 is covered with tests
Checklist