Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flank run --dump-shards --obfuscate #823

Closed
bootstraponline opened this issue May 28, 2020 · 0 comments · Fixed by #837
Closed

flank run --dump-shards --obfuscate #823

bootstraponline opened this issue May 28, 2020 · 0 comments · Fixed by #837
Assignees
Labels
Milestone

Comments

@bootstraponline
Copy link
Contributor

Is your feature request related to a problem? Please describe.

flank run --dump-shards contains internal names of tests. Add an --obfuscate option so that users can easily share their shards for debugging without exposing internal details.

Describe the solution you'd like

Figure out a human friendly way of uniquely replacing internal test names. This ticket will involve creating the solution and approach.

Example input:

"class com.example.app.ExampleUiTest#testPasses"

Example output:

"class aaa.bbbbb.ccc.DddddddEeFfff#ggggHhhhhh"

That's not super readable however it displays the general idea. The obfuscated names should still be unique so we can easily debug problems.

@bootstraponline bootstraponline added this to the June milestone May 28, 2020
@piotradamczyk5 piotradamczyk5 self-assigned this Jun 3, 2020
piotradamczyk5 pushed a commit that referenced this issue Jun 8, 2020
…-obfuscation-option

# Conflicts:
#	release_notes.md
piotradamczyk5 pushed a commit that referenced this issue Jun 8, 2020
…option' into #823-add-dump-shard-obfuscation-option
piotradamczyk5 pushed a commit that referenced this issue Jun 17, 2020
# Conflicts:
#	release_notes.md
#	test_runner/docs/ascii/flank.jar_-android-run.adoc
#	test_runner/docs/ascii/flank.jar_-firebase-test-android-run.adoc
#	test_runner/docs/ascii/flank.jar_-firebase-test-ios-run.adoc
#	test_runner/docs/ascii/flank.jar_-ios-run.adoc
piotradamczyk5 pushed a commit that referenced this issue Jun 17, 2020
piotradamczyk5 pushed a commit that referenced this issue Jun 19, 2020
…-obfuscation-option

# Conflicts:
#	release_notes.md
piotradamczyk5 pushed a commit that referenced this issue Jun 19, 2020
piotradamczyk5 pushed a commit that referenced this issue Jun 19, 2020
piotradamczyk5 added a commit that referenced this issue Jun 19, 2020
* #823 Added obfuscate option to dump shards

* #837 Update release notes

* Update ObfuscationGsonTest.kt

* Update ObfuscationTest.kt

* #823 Added obfuscate option to dump shards

* #823 Added obfuscate option to dump shards

* #823 Handle case when method name is not present

* #823 update docs

* #823 update tests

* #823 update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants