Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test filters fail with Additional Test Apks #745

Closed
runningcode opened this issue Apr 25, 2020 · 2 comments · Fixed by #746
Closed

Test filters fail with Additional Test Apks #745

runningcode opened this issue Apr 25, 2020 · 2 comments · Fixed by #746
Assignees
Labels
Milestone

Comments

@runningcode
Copy link
Contributor

When using test filters and additional test apks:
If we use a filter which only matches tests in the instrumentation test apk but matches 0 tests in an additional test apk, flank will fail with:
All tests filtered out

Is this the expected result? In 8.1.0 flank would run successfully. In the current flank snapshot this fails in the above manner. What is the expected behavior?

@pawelpasterz
Copy link
Contributor

pawelpasterz commented Apr 25, 2020

Filters are used to match tests in each apk-test pair separately. If pair has all tests filtered out, flank run is terminated. Looks like we are missing that case you mentioned. Thanks for reporting that!

cc @bootstraponline

@bootstraponline
Copy link
Contributor

We should probably ignore when there are zero tests in a particular APK instead of erroring. #739 is a related bug.Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants