Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip apks with 0 tests instead of failing #739

Closed
bootstraponline opened this issue Apr 24, 2020 · 0 comments · Fixed by #741
Closed

Skip apks with 0 tests instead of failing #739

bootstraponline opened this issue Apr 24, 2020 · 0 comments · Fixed by #741
Milestone

Comments

@bootstraponline
Copy link
Contributor

Issue reported via Slack. Giorgio will submit a pull request. Related issue in Fladle: runningcode/fladle#96

Giorgio Antonioli
Hi, currently Flank doesn’t support test APKs with zero tests on Android so currently we are detecting the test count in the bytecode before including the test APK with Flank. Would it be ok if I open a PR to implement this inside Flank? This would be easier since you are using DexParser already.

When you have a project with several modules and flank is configured automatically on each Android module. If you have several modules, not configuring Flank automatically for each module is dangerous since you usually want to run all your tests with your CI.

Imagine this scenario:

Module A has zero tests currently and Flank is not applied since there aren’t tests to run. A dev adds a test on module A. He should remember to add Flank manually if that is the first instrumented test of the module A. 99% of the time he will forget to do it and the tests won’t run on the CI for that given module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants