Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time info incomplete when using orchestrator #557

Closed
bootstraponline opened this issue May 18, 2019 · 0 comments · Fixed by #684
Closed

Time info incomplete when using orchestrator #557

bootstraponline opened this issue May 18, 2019 · 0 comments · Fixed by #684
Assignees
Labels
Milestone

Comments

@bootstraponline
Copy link
Contributor

bootstraponline commented May 18, 2019

Shard time is calculated by summing all test durations together. FTL doesn't report orchestrator setup/teardown. That means individual test times and overall shard times used by flank are incorrect.

  • Work with FTL to get valid time data from the API
  • Update sharding algorithm to use real time values

Example JUnit XML result with 3s per test overhead:

<testsuite name="" tests="2" failures="0" errors="0" skipped="0" time="8s" timestamp="2019-05-13T16:03:42" hostname="localhost">
    <testcase name="test1" classname="com.example.ExampleTest" time="1.0"/>
    <testcase name="test2" classname="com.example.ExampleTest" time="1.0"/>
</testsuite>

Total time in the JUnit XML is valid <testsuite time="8s". Individual test times don't include overhead.

@bootstraponline bootstraponline removed the 8 label Mar 6, 2020
@bootstraponline bootstraponline added this to the May 2020 milestone Mar 6, 2020
@jan-goral jan-goral self-assigned this Mar 24, 2020
Fry-kun added a commit that referenced this issue Apr 13, 2023
…ocessing deflake reruns & reporting negative test case times.

Overhead (as described in #557) no longer exists in FTL, so this feature is not useful anymore.

Fixes #2363
Fry-kun added a commit that referenced this issue Apr 13, 2023
…ocessing deflake reruns & reporting negative test case times. (#2364)

Overhead (as described in #557) no longer exists in FTL, so this feature is not useful anymore.

Fixes #2363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants