Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structural output - ListNetworkProfiles #1864

Closed
jan-goral opened this issue Apr 26, 2021 · 0 comments · Fixed by #1915
Closed

Structural output - ListNetworkProfiles #1864

jan-goral opened this issue Apr 26, 2021 · 0 comments · Fixed by #1915
Assignees
@piotradamczyk5
Labels
Feature Tiger 🐯

Comments

@jan-goral
Copy link
Contributor

Plan

According to the specification described in epic #1728, implement the structural output for the command and move the console logging to layer CLI.

Command

ListNetworkProfiles
@piotradamczyk5 piotradamczyk5 self-assigned this May 11, 2021
@piotradamczyk5 piotradamczyk5 mentioned this issue May 11, 2021
Merged
1 task
@mergify mergify bot closed this as completed in #1915 May 12, 2021
mergify bot pushed a commit that referenced this issue May 12, 2021
@piotradamczyk5
refactor: Structural output list network profiles (#1915)
8f745b7 
Fixes #1864

## Test Plan
> How do we know the code works?

- code is refactored as described in #1864
- `flank firebase test network-profiles list` works like before

## Checklist

- [x] Refactored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piotradamczyk5 piotradamczyk5

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Structural output list network profiles Flank/flank
2 participants
@jan-goral @piotradamczyk5