Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structural output - ListIosVersions #1862

Closed
jan-goral opened this issue Apr 26, 2021 · 0 comments · Fixed by #1924
Closed

Structural output - ListIosVersions #1862

jan-goral opened this issue Apr 26, 2021 · 0 comments · Fixed by #1924
Assignees
@adamfilipow92
Labels
Feature Tiger 🐯

Comments

@jan-goral
Copy link
Contributor

Plan

According to the specification described in epic #1728, implement the structural output for the command and move the console logging to layer CLI.

Command

ListIosVersions
@Sloox Sloox mentioned this issue Apr 30, 2021
Closed
@Sloox Sloox assigned Sloox and unassigned Sloox May 10, 2021
@adamfilipow92 adamfilipow92 self-assigned this May 10, 2021
@adamfilipow92 adamfilipow92 mentioned this issue May 12, 2021
Merged
1 task
@mergify mergify bot closed this as completed in #1924 May 12, 2021
mergify bot pushed a commit that referenced this issue May 12, 2021
@adamfilipow92
refactor: Structural output list ios versions (#1924)
cfb302e 
Fixes #1862 

## Test Plan
> How do we know the code works?

1. Run flank ```flank  ios versions list```
2. See output

```
┌───────────────┬───────────────┬───────────────┬─────────┬──────────────────────────────┐
│ OS_VERSION_ID │ MAJOR_VERSION │ MINOR_VERSION │  TAGS   │ SUPPORTED_XCODE_VERSION_IDS  │
├───────────────┼───────────────┼───────────────┼─────────┼──────────────────────────────┤
│     10.3      │      10       │       3       │         │ 10.3, 11.6, 11.7, 12.1, 12.3 │
│     11.2      │      11       │       2       │         │ 10.3, 11.6, 11.7, 12.1, 12.3 │
│     11.4      │      11       │       4       │         │ 10.3, 11.6, 11.7, 12.1, 12.3 │
│     12.0      │      12       │ UNKNOWN       │         │ 10.3, 11.6, 11.7, 12.1, 12.3 │
│     12.1      │      12       │       1       │         │ 10.3, 11.6, 11.7, 12.1, 12.3 │
│     12.2      │      12       │       2       │         │ 10.3, 11.6, 11.7, 12.1, 12.3 │
│     12.3      │      12       │       3       │         │ 10.3, 11.6, 11.7, 12.1, 12.3 │
│     12.4      │      12       │       4       │         │ 11.6, 11.7, 12.1, 12.3       │
│     13.2      │      13       │       2       │         │ 11.6, 11.7, 12.1, 12.3       │
│     13.3      │      13       │       3       │         │ 11.6, 11.7, 12.1, 12.3       │
│     13.6      │      13       │       6       │         │ 11.6, 11.7, 12.1, 12.3       │
│     14.1      │      14       │       1       │ default │ 12.1, 12.3                   │
└───────────────┴───────────────┴───────────────┴─────────┴──────────────────────────────┘

Total run duration: 0m  4s
```

## Checklist

- [X] Refactored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamfilipow92 adamfilipow92

Labels
Feature Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Structural output list ios versions Flank/flank
3 participants
@Sloox @jan-goral @adamfilipow92