Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ftl.cli to ftl.presentation.cli #1734

Closed
jan-goral opened this issue Mar 24, 2021 · 1 comment · Fixed by #1774
Closed

Move ftl.cli to ftl.presentation.cli #1734

jan-goral opened this issue Mar 24, 2021 · 1 comment · Fixed by #1774
Assignees
@Sloox
Labels
Refactor Snake 🐍

Comments

@jan-goral
Copy link
Contributor

jan-goral commented Mar 24, 2021 •
edited
Loading

A cosmetic change but required to keep a high level of consistency with component diagram

Just copy and paste the whole ftl.cli package into ftl.presentation.cli.
Make sure the imports were updated properly.
@piotradamczyk5
Copy link
Contributor

@jan-gogo bad link attached

@Sloox Sloox self-assigned this Apr 2, 2021
@Sloox Sloox mentioned this issue Apr 2, 2021
Merged
2 tasks
@mergify mergify bot closed this as completed in #1774 Apr 7, 2021
mergify bot pushed a commit that referenced this issue Apr 7, 2021
@Sloox
refactor: Move cli to presentation (#1774)
536f3f6 
Fixes #1734 

## Test Plan
There is no changes besides cosmetic. 

## Checklist
- [x] Unit tested
- [x] Integration tests updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sloox Sloox

Labels
Refactor Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Move cli to presentation Flank/flank
3 participants
@Sloox @jan-goral @piotradamczyk5