Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow device & shard count validation to be skipped #1710

Closed
inktomi opened this issue Mar 17, 2021 · 1 comment · Fixed by #1715
Closed

Allow device & shard count validation to be skipped #1710

inktomi opened this issue Mar 17, 2021 · 1 comment · Fixed by #1715
Assignees
@pawelpasterz
Labels
Feature New Option Used to track PR with new configuration option (useful when updating fladle) P0 Tiger 🐯

Comments

@inktomi
Copy link

inktomi commented Mar 17, 2021 •
edited
Loading

As a firebase test lab user, I may be offered access from time to time above the normal limits. As a flank & fladle user, I would like to be able to pass in customized config values to use my account to the fullest - but the configuration validation prevents it.

I would like the ability to skip config validation by passing in a flag at runtime. This flag could even be part of the config, it doesn't need to be a command line option. In the event of having an invalid config but passing the skip validation flag, Flank should crash (unparsable config) or pass the values provided (eg, 1000 shards, or FluffyBunny device type, etc).

As this is part of Flank that's (correctly!) built in, it's not currently possible to work around this when passing in otherwise invalid parameters.
@jan-goral
Copy link
Contributor

For estimation

  1. Add new option skip-config-validation
  2. Update implementation for skipping o args validation if this option is used.

@jan-goral jan-goral added the New Option Used to track PR with new configuration option (useful when updating fladle) label Mar 18, 2021
@jan-goral jan-goral mentioned this issue Mar 18, 2021
Merged
1 task
mergify bot pushed a commit that referenced this issue Mar 18, 2021
@pawelpasterz
feat: Add support for emulator devices (#1711)
f32ae8b 
In the scope of #1710

PR adds support for `EMULATOR` devices

## Test Plan
> How do we know the code works?

1. build flank locally with `./gradlew flankFullRun`
2. ensure you are logged to `flank-open-source` project
3. run `flank firebase test android models list`
4. you should see new devices of type `EMULATOR`
5. run a simple test with
    ```
      device:
         - model: NexusLowResEmulator
           version: 28
    ```
6. tests should finish normally

## Checklist

- [x] Unit tested
@pawelpasterz pawelpasterz self-assigned this Mar 19, 2021
@pawelpasterz pawelpasterz mentioned this issue Mar 21, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelpasterz pawelpasterz

Labels
Feature New Option Used to track PR with new configuration option (useful when updating fladle) P0 Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add option to skip config validation Flank/flank
4 participants
@inktomi @bootstraponline @pawelpasterz @jan-goral