Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS IT Windows: Fix Windows Paths & Linking issues #1686

Closed
Sloox opened this issue Mar 11, 2021 · 0 comments · Fixed by #1739
Closed

iOS IT Windows: Fix Windows Paths & Linking issues #1686

Sloox opened this issue Mar 11, 2021 · 0 comments · Fixed by #1739
Assignees
@Sloox
Labels
Feature P2 Tiger 🐯

Comments

@Sloox
Copy link
Contributor

Sloox commented Mar 11, 2021 •
edited
Loading

Author the user story for this feature
Fix the issue with linking files (currently flank makes a symbolic link for the nm.exe file that cannot be used. We need an alternative)
Describe the solution
It is possible to simply copy the file and rename it appropriately

It needs to be tested that it works as intended.
@zuziaka zuziaka added the P2 label Mar 15, 2021
@Sloox Sloox self-assigned this Mar 19, 2021
@Sloox Sloox mentioned this issue Mar 26, 2021
Merged
1 task
Sloox added a commit that referenced this issue Mar 26, 2021
@Sloox
Merge branch 'master' into #1686-IT-tests
221fef6
Sloox added a commit that referenced this issue Mar 29, 2021
@Sloox
Merge branch 'master' into #1686-IT-tests
6be5853
Sloox added a commit that referenced this issue Mar 29, 2021
@Sloox
Merge branch '#1686-IT-tests' of https://github.com/Flank/flank into #…
502d2e4 
…1686-IT-tests
Sloox added a commit that referenced this issue Mar 29, 2021
@Sloox
Merge branch 'master' into #1686-IT-tests
6c8b9af
Sloox added a commit that referenced this issue Mar 30, 2021
@Sloox
Merge branch 'master' into #1686-IT-tests
e842f50
Sloox added a commit that referenced this issue Mar 30, 2021
@Sloox
Merge branch '#1686-IT-tests' of https://github.com/Flank/flank into #…
631e180 
…1686-IT-tests
Sloox added a commit that referenced this issue Mar 31, 2021
@Sloox
Merge branch 'master' into #1686-IT-tests
4792024
@mergify mergify bot closed this as completed in #1739 Apr 1, 2021
mergify bot pushed a commit that referenced this issue Apr 1, 2021
@Sloox
feat: Windows IOS integration tests (#1739)
c7f029f 
Fixes #1686 

## Test Plan
> How do we know the code works?

IT tests will work

## Checklist
- [x] Integration tests updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sloox Sloox

Labels
Feature P2 Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Windows IOS integration tests Flank/flank
2 participants
@Sloox @zuziaka